linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gpiccoli@linux.vnet.ibm.com (Guilherme G. Piccoli)
Subject: [PATCH 0/2] 2 patches about asynchronous events notification
Date: Fri, 17 Jun 2016 14:21:13 -0300	[thread overview]
Message-ID: <1466184075-10471-1-git-send-email-gpiccoli@linux.vnet.ibm.com> (raw)

The 2 patches in this small series are related to asynchronous events' handling.

The 1st aims to print textual information instead of just print the event code.
The 2nd patch enables asynchronous events notification by default.

There are some points below, for which I'd be glad to hear some suggestions!

1) In the 1st patch, we do first a direct lookup in a table and then we
fallback to full table search in case direct lookup does not succeed. We can
rely in direct lookup solely if we are sure the NVMe spec. won't ever add
events with non-incremental codes. Since I cannot guarantee this myself, my
choice was to keep the full table search (which code won't be reached with
current events of the spec.);

2) The 2nd patch was sent as a RFC, because I'm not sure if there is some
con in enabling those events by default; I might be missing some caveat here.

Thanks in advance.



Guilherme G. Piccoli (2):
  nvme: introduce asynchronous events textual output
  nvme: enable asynchronous events notification by default

 drivers/nvme/host/core.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++--
 drivers/nvme/host/nvme.h |  9 ++++++
 drivers/nvme/host/pci.c  | 16 ++++++++++
 3 files changed, 102 insertions(+), 2 deletions(-)

-- 
2.1.0

             reply	other threads:[~2016-06-17 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 17:21 Guilherme G. Piccoli [this message]
2016-06-17 17:21 ` [PATCH 1/2] nvme: introduce asynchronous events textual output Guilherme G. Piccoli
2016-06-17 17:21 ` [PATCH 2/2] [RFC] nvme: enable asynchronous events notification by default Guilherme G. Piccoli
2016-06-20  6:55   ` Sagi Grimberg
2016-06-20 17:03     ` Guilherme G. Piccoli
2016-06-20 20:21       ` Keith Busch
2016-06-24  8:17         ` Christoph Hellwig
2016-06-28 15:11           ` Keith Busch
2016-06-29  4:17             ` Gabriel Krisman Bertazi
2016-07-06 22:47           ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466184075-10471-1-git-send-email-gpiccoli@linux.vnet.ibm.com \
    --to=gpiccoli@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).