From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request()
Date: Tue, 12 Jul 2016 07:18:43 -0700 [thread overview]
Message-ID: <1468333123.6604.2.camel@linux.intel.com> (raw)
In-Reply-To: <1468321577-16278-1-git-send-email-weiyj_lk@163.com>
On Tue, 2016-07-12@11:06 +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> PTR_ERR should be applied before its argument is reassigned,
> otherwise the
> return value will be set to 0, not error code.
Another good catch.
Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> if (IS_ERR(req->mr)) {
> - req->mr = NULL;
> ret = PTR_ERR(req->mr);
> + req->mr = NULL;
> }
next prev parent reply other threads:[~2016-07-12 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 11:06 [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request() weiyj_lk
2016-07-12 14:18 ` J Freyensee [this message]
2016-07-12 15:27 ` Jens Axboe
2016-07-13 10:36 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468333123.6604.2.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).