From: roland@kernel.org (Roland Dreier)
Subject: [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data
Date: Sun, 31 Jul 2016 00:27:39 -0700 [thread overview]
Message-ID: <1469950060-18098-1-git-send-email-roland@kernel.org> (raw)
From: Roland Dreier <roland@purestorage.com>
Zero out the full nvme_rdma_cm_req structure before sending it.
Otherwise we end up leaking kernel memory in the reserved field, which
might break forward compatibility in the future.
Signed-off-by: Roland Dreier <roland at purestorage.com>
---
drivers/nvme/host/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3e3ce2b0424e..b96b88369871 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1269,7 +1269,7 @@ static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)
{
struct nvme_rdma_ctrl *ctrl = queue->ctrl;
struct rdma_conn_param param = { };
- struct nvme_rdma_cm_req priv;
+ struct nvme_rdma_cm_req priv = { };
int ret;
param.qp_num = queue->qp->qp_num;
--
2.7.4
next reply other threads:[~2016-07-31 7:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 7:27 Roland Dreier [this message]
2016-07-31 7:27 ` [PATCH 2/2] nvme-rdma: Add handling for connecting to IPv6 targets Roland Dreier
2016-07-31 8:45 ` Sagi Grimberg
2016-07-31 10:58 ` Sagi Grimberg
2016-07-31 15:33 ` Roland Dreier
2016-08-01 5:58 ` Sagi Grimberg
2016-08-01 6:15 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
2016-08-01 11:24 ` Sagi Grimberg
2016-08-01 15:50 ` Christoph Hellwig
2016-08-01 16:06 ` Roland Dreier
2016-08-02 6:43 ` Sagi Grimberg
2016-08-02 12:51 ` Christoph Hellwig
2016-08-18 7:44 ` Sagi Grimberg
2016-08-22 4:44 ` Roland Dreier
2016-08-22 6:47 ` Sagi Grimberg
2016-08-02 6:41 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
2016-07-31 8:44 ` [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data Sagi Grimberg
2016-08-01 11:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469950060-18098-1-git-send-email-roland@kernel.org \
--to=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).