From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v2] nvme-cli: user-defined hostnqn option for discover
Date: Mon, 01 Aug 2016 14:32:59 -0700 [thread overview]
Message-ID: <1470087179.6134.51.camel@linux.intel.com> (raw)
In-Reply-To: <20160801111859.GA28246@infradead.org>
On Mon, 2016-08-01@04:18 -0700, Christoph Hellwig wrote:
> On Fri, Jul 29, 2016@01:38:39PM -0700, Jay Freyensee wrote:
> > The nvme-cli will always use the default hostnqn
> > in /dev/nvme-fabrics for the discovery query, even though
> > both the NVMe Target and NVMe Host rdma implementations allow
> > user-defined hostnqn naming.
> >
> > For example, this is the current, somewhat broken behavior if you
> > used your own hostnqn provision naming on the NVMe kernel target:
>
> Maybe -n or -N would be a good choice for the short option flag?
I thought Roy's suggestion for -q was fine.
>
> Otherwise this looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
Cool, thanks.
>
> Any chance you could also send a patch that reads /etc/nvme/hostnqn
> for a default hostnqn so that we can have a persistent one?
I'm a tad unclear what is the request? The default hostnqn is buried
inside /dev/nvme-fabrics. You want nvme-cli to read out the default
hostnqn from /dev/nvme-fabrics and place it in /etc/nvme/hostnqn?
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2016-08-01 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 20:38 [PATCH v2] *** Discovery feature fix in nvme-cli *** Jay Freyensee
2016-07-29 20:38 ` [PATCH v2] nvme-cli: user-defined hostnqn option for discover Jay Freyensee
2016-08-01 11:18 ` Christoph Hellwig
2016-08-01 21:32 ` J Freyensee [this message]
2016-08-02 6:48 ` Sagi Grimberg
2016-08-02 23:31 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470087179.6134.51.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).