From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v2 4/5] nvme-loop: Remove duplicate call to nvme_remove_namespaces
Date: Tue, 2 Aug 2016 10:53:38 +0300 [thread overview]
Message-ID: <1470124419-30405-5-git-send-email-sagi@grimberg.me> (raw)
In-Reply-To: <1470124419-30405-1-git-send-email-sagi@grimberg.me>
nvme_uninit_ctrl already does that for us. Note that we
reordered nvme_loop_shutdown_ctrl with nvme_uninit_ctrl
but its safe because we want controller uninit to happen
before we shutdown the transport resources.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/loop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 94e782987cc9..7affd40a6b33 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -414,9 +414,8 @@ static void nvme_loop_del_ctrl_work(struct work_struct *work)
struct nvme_loop_ctrl *ctrl = container_of(work,
struct nvme_loop_ctrl, delete_work);
- nvme_remove_namespaces(&ctrl->ctrl);
- nvme_loop_shutdown_ctrl(ctrl);
nvme_uninit_ctrl(&ctrl->ctrl);
+ nvme_loop_shutdown_ctrl(ctrl);
nvme_put_ctrl(&ctrl->ctrl);
}
@@ -501,7 +500,6 @@ out_free_queues:
nvme_loop_destroy_admin_queue(ctrl);
out_disable:
dev_warn(ctrl->ctrl.device, "Removing after reset failure\n");
- nvme_remove_namespaces(&ctrl->ctrl);
nvme_uninit_ctrl(&ctrl->ctrl);
nvme_put_ctrl(&ctrl->ctrl);
}
--
1.9.1
next prev parent reply other threads:[~2016-08-02 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 7:53 [PATCH v2 0/5] Some fabrics fixes Sagi Grimberg
2016-08-02 7:53 ` [PATCH v2 1/5] nvme-rdma: Fix device removal handling Sagi Grimberg
2016-08-02 7:53 ` [PATCH v2 2/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces Sagi Grimberg
2016-08-03 9:03 ` Christoph Hellwig
2016-08-02 7:53 ` [PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller Sagi Grimberg
2016-08-03 9:03 ` Christoph Hellwig
2016-08-02 7:53 ` Sagi Grimberg [this message]
2016-08-03 9:03 ` [PATCH v2 4/5] nvme-loop: Remove duplicate call to nvme_remove_namespaces Christoph Hellwig
2016-08-02 7:53 ` [PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can Sagi Grimberg
2016-08-03 9:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470124419-30405-5-git-send-email-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).