From: james_p_freyensee@linux.intel.com (Jay Freyensee)
Subject: [PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val
Date: Fri, 5 Aug 2016 17:54:11 -0700 [thread overview]
Message-ID: <1470444851-7459-3-git-send-email-james_p_freyensee@linux.intel.com> (raw)
In-Reply-To: <1470444851-7459-1-git-send-email-james_p_freyensee@linux.intel.com>
Per NVMe-over-Fabrics 1.0 spec, sqsize is represented as
a 0-based value.
Also per spec, the RDMA binding values shall be set
to sqsize, which makes hsqsize and hrqsize 0-based values.
Thus, the sqsize at the NVMe Fabrics level is now:
[root at fedora23-fabrics-host1 for-48]# dmesg
[ 318.720645] nvme_fabrics: nvmf_connect_admin_queue(): sqsize for
admin queue: 31
[ 318.720884] nvme nvme0: creating 16 I/O queues.
[ 318.810114] nvme_fabrics: nvmf_connect_io_queue(): sqsize for i/o
queue: 127
Reported-by: Daniel Verkamp <daniel.verkamp at intel.com>
Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
---
drivers/nvme/host/rdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index ff44167..6300b10 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1288,8 +1288,8 @@ static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)
priv.hrqsize = cpu_to_le16(queue->ctrl->ctrl.admin_sqsize);
priv.hsqsize = cpu_to_le16(queue->ctrl->ctrl.admin_sqsize);
} else {
- priv.hrqsize = cpu_to_le16(queue->queue_size);
- priv.hsqsize = cpu_to_le16(queue->queue_size);
+ priv.hrqsize = cpu_to_le16(queue->ctrl->ctrl.sqsize);
+ priv.hsqsize = cpu_to_le16(queue->ctrl->ctrl.sqsize);
}
ret = rdma_connect(queue->cm_id, ¶m);
@@ -1921,7 +1921,7 @@ static struct nvme_ctrl *nvme_rdma_create_ctrl(struct device *dev,
* common I/O queue size value (sqsize, opts->queue_size).
*/
ctrl->ctrl.admin_sqsize = NVMF_AQ_DEPTH-1;
- ctrl->ctrl.sqsize = opts->queue_size;
+ ctrl->ctrl.sqsize = opts->queue_size-1;
ctrl->ctrl.kato = opts->kato;
ret = -ENOMEM;
--
2.7.4
next prev parent reply other threads:[~2016-08-06 0:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:54 [PATCH 0/2] nvme-fabrics: sqsize bug fixes Jay Freyensee
2016-08-06 0:54 ` [PATCH 1/2] nvme-rdma: tell fabrics layer admin queue depth Jay Freyensee
2016-08-07 7:20 ` Sagi Grimberg
2016-08-08 7:05 ` Christoph Hellwig
2016-08-08 16:11 ` J Freyensee
2016-08-06 0:54 ` Jay Freyensee [this message]
2016-08-07 7:29 ` [PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val Sagi Grimberg
2016-08-08 7:06 ` Christoph Hellwig
2016-08-08 16:30 ` Verkamp, Daniel
[not found] ` <9A947B1F6D0FF74CB5D6ACFF43B473F3A3A45C75@ORSMSX112.amr.corp.intel.com>
2016-08-08 18:39 ` J Freyensee
2016-08-08 16:08 ` Verkamp, Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470444851-7459-3-git-send-email-james_p_freyensee@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).