From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH nvme-cli 3/4] fabrics: Remove redundant build_options
Date: Sun, 7 Aug 2016 15:19:24 +0300 [thread overview]
Message-ID: <1470572365-20674-4-git-send-email-sagi@grimberg.me> (raw)
In-Reply-To: <1470572365-20674-1-git-send-email-sagi@grimberg.me>
We call it again in do_discover.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
fabrics.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fabrics.c b/fabrics.c
index 9f99e6175428..8c1a8331cc45 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -584,7 +584,6 @@ static int do_discover(char *argstr, bool connect)
int discover(const char *desc, int argc, char **argv, bool connect)
{
char argstr[BUF_SIZE];
- int ret;
const struct argconfig_commandline_options command_line_options[] = {
{"transport", 't', "LIST", CFG_STRING, &cfg.transport, required_argument,
"transport type" },
@@ -599,12 +598,6 @@ int discover(const char *desc, int argc, char **argv, bool connect)
argconfig_parse(argc, argv, desc, command_line_options, &cfg, sizeof(cfg));
- cfg.nqn = NVME_DISC_SUBSYS_NAME;
-
- ret = build_options(argstr, BUF_SIZE);
- if (ret)
- return ret;
-
return do_discover(argstr, connect);
}
--
1.9.1
next prev parent reply other threads:[~2016-08-07 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 12:19 [PATCH nvme-cli 0/4] Some useful fabrics patches Sagi Grimberg
2016-08-07 12:19 ` [PATCH nvme-cli 1/4] fabrics: Allow ipv6 address resolution Sagi Grimberg
2016-08-08 6:55 ` Christoph Hellwig
2016-08-08 20:53 ` J Freyensee
2016-08-07 12:19 ` [PATCH nvme-cli 2/4] fabrics: stringify discover output Sagi Grimberg
2016-08-08 6:59 ` Christoph Hellwig
2016-08-08 8:41 ` Sagi Grimberg
2016-08-07 12:19 ` Sagi Grimberg [this message]
2016-08-08 7:01 ` [PATCH nvme-cli 3/4] fabrics: Remove redundant build_options Christoph Hellwig
2016-08-08 8:41 ` Sagi Grimberg
2016-08-07 12:19 ` [PATCH RFC nvme-cli 4/4] fabrics: Allow discover params to come from a conf file Sagi Grimberg
2016-08-08 7:03 ` Christoph Hellwig
2016-08-08 8:45 ` Sagi Grimberg
2016-08-08 21:13 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470572365-20674-4-git-send-email-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).