From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH 1/2] nvme-rdma: tell fabrics layer admin queue depth
Date: Mon, 08 Aug 2016 09:11:12 -0700 [thread overview]
Message-ID: <1470672672.3379.3.camel@linux.intel.com> (raw)
In-Reply-To: <20160808070534.GA12902@lst.de>
On Mon, 2016-08-08@09:05 +0200, Christoph Hellwig wrote:
> On Sun, Aug 07, 2016@10:20:38AM +0300, Sagi Grimberg wrote:
> >
> > No need for admin_sqsize member, its always set to NVMF_AQ_DEPTH-1,
> > just use that...
>
Ok, but this allows the code to grow into the ASQSZ field (whenever
this is implemented or not), which is done on discovery that each new
controller discovered could have a different size Admin queue field.
But I'm perfectly happy using this,it makes the code a bit easier.
> Agreed.
>
next prev parent reply other threads:[~2016-08-08 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:54 [PATCH 0/2] nvme-fabrics: sqsize bug fixes Jay Freyensee
2016-08-06 0:54 ` [PATCH 1/2] nvme-rdma: tell fabrics layer admin queue depth Jay Freyensee
2016-08-07 7:20 ` Sagi Grimberg
2016-08-08 7:05 ` Christoph Hellwig
2016-08-08 16:11 ` J Freyensee [this message]
2016-08-06 0:54 ` [PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val Jay Freyensee
2016-08-07 7:29 ` Sagi Grimberg
2016-08-08 7:06 ` Christoph Hellwig
2016-08-08 16:30 ` Verkamp, Daniel
[not found] ` <9A947B1F6D0FF74CB5D6ACFF43B473F3A3A45C75@ORSMSX112.amr.corp.intel.com>
2016-08-08 18:39 ` J Freyensee
2016-08-08 16:08 ` Verkamp, Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470672672.3379.3.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).