From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH RFC nvme-cli 4/4] fabrics: Allow discover params to come from a conf file
Date: Mon, 08 Aug 2016 14:13:33 -0700 [thread overview]
Message-ID: <1470690813.4368.15.camel@linux.intel.com> (raw)
In-Reply-To: <1470572365-20674-5-git-send-email-sagi@grimberg.me>
On Sun, 2016-08-07@15:19 +0300, Sagi Grimberg wrote:
I think it's a good idea! ?A few minor things.
> Allow the user to just run "nvme discover" or "nvme connect-all"
> in case it finds a default /etc/nvme/nvmf_disc conf file.
>
1. I think the "official trademark" of NVMe-over-Fabrics is NVMeo-F.
?So maybe tweak the conf file to /etc/nvme/nvmeof_disc (the dash
between the o and F is weird and would look dumb here).
2. Be nice to see a quick documentation example of contents of the conf
file in this patch as we don't have any documentation yet (this way
someone, not necessarily the author of this patch, can more easily
write the documentation).
Jay
prev parent reply other threads:[~2016-08-08 21:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 12:19 [PATCH nvme-cli 0/4] Some useful fabrics patches Sagi Grimberg
2016-08-07 12:19 ` [PATCH nvme-cli 1/4] fabrics: Allow ipv6 address resolution Sagi Grimberg
2016-08-08 6:55 ` Christoph Hellwig
2016-08-08 20:53 ` J Freyensee
2016-08-07 12:19 ` [PATCH nvme-cli 2/4] fabrics: stringify discover output Sagi Grimberg
2016-08-08 6:59 ` Christoph Hellwig
2016-08-08 8:41 ` Sagi Grimberg
2016-08-07 12:19 ` [PATCH nvme-cli 3/4] fabrics: Remove redundant build_options Sagi Grimberg
2016-08-08 7:01 ` Christoph Hellwig
2016-08-08 8:41 ` Sagi Grimberg
2016-08-07 12:19 ` [PATCH RFC nvme-cli 4/4] fabrics: Allow discover params to come from a conf file Sagi Grimberg
2016-08-08 7:03 ` Christoph Hellwig
2016-08-08 8:45 ` Sagi Grimberg
2016-08-08 21:13 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470690813.4368.15.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).