From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v2 nvme-cli 1/4] fabrics: Allow ipv6 address resolution
Date: Mon, 08 Aug 2016 14:17:20 -0700 [thread overview]
Message-ID: <1470691040.4368.16.camel@linux.intel.com> (raw)
In-Reply-To: <1470657480-5868-2-git-send-email-sagi@grimberg.me>
On Mon, 2016-08-08@14:57 +0300, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> ---
> ?fabrics.c | 3 ++-
> ?1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fabrics.c b/fabrics.c
> index 8a174d41b82b..961335d45bd2 100644
> --- a/fabrics.c
> +++ b/fabrics.c
> @@ -438,7 +438,8 @@ static int connect_ctrl(struct
> nvmf_disc_rsp_page_entry *e)
> ? /* we can safely ignore the rest of the entries */
> ? break;
> ? case NVMF_TRTYPE_RDMA:
> - if (e->adrfam != NVMF_ADDR_FAMILY_IP4) {
> + if (e->adrfam != NVMF_ADDR_FAMILY_IP4 &&
> + ????e->adrfam != NVMF_ADDR_FAMILY_IP6) {
If we are going to roll this patch series again, maybe better to just
go ahead and do the case()?
I'm indifferent either way.
> ? fprintf(stderr, "skipping unsupported
> adrfam\n");
> ? return -EINVAL;
> ? }
next prev parent reply other threads:[~2016-08-08 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 11:57 [PATCH v2 nvme-cli 0/4] Useful fabrics patches Sagi Grimberg
2016-08-08 11:57 ` [PATCH v2 nvme-cli 1/4] fabrics: Allow ipv6 address resolution Sagi Grimberg
2016-08-08 21:17 ` J Freyensee [this message]
2016-08-08 11:57 ` [PATCH v2 nvme-cli 2/4] fabrics: stringify discover output Sagi Grimberg
2016-08-08 13:31 ` Christoph Hellwig
2016-08-08 11:57 ` [PATCH v2 nvme-cli 3/4] fabrics: Allow discover params to come from a conf file Sagi Grimberg
2016-08-08 13:35 ` Christoph Hellwig
2016-08-08 21:29 ` J Freyensee
2016-08-09 6:52 ` Sagi Grimberg
2016-08-08 21:51 ` J Freyensee
2016-08-09 6:58 ` Sagi Grimberg
2016-08-08 11:58 ` [PATCH v2 nvme-cli 4/4] fabrics: Take the hostnqn parameter from a conf file if not given Sagi Grimberg
2016-08-08 13:36 ` Christoph Hellwig
2016-08-08 21:37 ` J Freyensee
2016-08-08 15:36 ` [PATCH v2 nvme-cli 0/4] Useful fabrics patches Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470691040.4368.16.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).