From: james_p_freyensee@linux.intel.com (Jay Freyensee)
Subject: [PATCH RFC 0/4] sqsize zero-based fixes
Date: Wed, 10 Aug 2016 21:07:14 -0700 [thread overview]
Message-ID: <1470888438-823-1-git-send-email-james_p_freyensee@linux.intel.com> (raw)
These patches are based on NVMe-over-Fabrics spec clarifcations
by Dave Minturn, one of the spec authors.
In summary, sqsize and hsqsize are 0-based
values, and hrqsize cannot be smaller than hsqsize+1.
There is an issue with these patches I haven't worked out yet,
thus the reason for RFC. The keep-alive timer is going
off then causes a kernel crash and I haven't worked out
exactly why yet, but I'm thinking
it has something to do with sqsize now being 0-based but
the RDMA implemenation layer's queue_size being 1's based.
Anyways, feedback appreciated as I continue
to work on how to fix this appropriately.
Jay Freyensee (4):
fabrics: define admin sqsize min default, per spec
nvme-rdma: fix sqsize/hsqsize/hrqsize per spec
nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
nvme-loop: set sqsize to 0-based value, per spec
drivers/nvme/host/fabrics.c | 16 +++++++++++++++-
drivers/nvme/host/nvme.h | 1 +
drivers/nvme/host/rdma.c | 19 ++++++++++++++++---
drivers/nvme/target/loop.c | 2 +-
drivers/nvme/target/rdma.c | 8 ++++----
5 files changed, 37 insertions(+), 9 deletions(-)
--
2.7.4
next reply other threads:[~2016-08-11 4:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 4:07 Jay Freyensee [this message]
2016-08-11 4:07 ` [PATCH RFC 1/4] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-11 9:01 ` Sagi Grimberg
2016-08-11 15:08 ` Christoph Hellwig
2016-08-11 16:33 ` J Freyensee
2016-08-11 4:07 ` [PATCH RFC 2/4] nvme-rdma: fix sqsize/hsqsize/hrqsize " Jay Freyensee
2016-08-11 7:03 ` Sagi Grimberg
2016-08-11 16:35 ` J Freyensee
2016-08-11 15:21 ` Christoph Hellwig
2016-08-11 16:40 ` J Freyensee
2016-08-11 23:24 ` J Freyensee
2016-08-11 4:07 ` [PATCH RFC 3/4] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-11 4:07 ` [PATCH RFC 4/4] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470888438-823-1-git-send-email-james_p_freyensee@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).