linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (Jay Freyensee)
Subject: [PATCH RFC 3/4] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
Date: Wed, 10 Aug 2016 21:07:17 -0700	[thread overview]
Message-ID: <1470888438-823-4-git-send-email-james_p_freyensee@linux.intel.com> (raw)
In-Reply-To: <1470888438-823-1-git-send-email-james_p_freyensee@linux.intel.com>

Now that the host will be sending hsqsize 0-based
values with hrqsize equaling hsqsize+1,
the target needs to be adjusted as well.

Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
---
 drivers/nvme/target/rdma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index e06d504..4a08946 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1004,11 +1004,11 @@ nvmet_rdma_parse_cm_connect_req(struct rdma_conn_param *conn,
 	queue->host_qid = le16_to_cpu(req->qid);
 
 	/*
-	 * req->hsqsize corresponds to our recv queue size
-	 * req->hrqsize corresponds to our send queue size
+	 * req->hsqsize corresponds to our recv queue size, plus 1
+	 * req->hrqsize corresponds to our send queue size, plus 1
 	 */
-	queue->recv_queue_size = le16_to_cpu(req->hsqsize);
-	queue->send_queue_size = le16_to_cpu(req->hrqsize);
+	queue->recv_queue_size = le16_to_cpu(req->hsqsize+1);
+	queue->send_queue_size = le16_to_cpu(req->hrqsize+1);
 
 	if (!queue->host_qid && queue->recv_queue_size > NVMF_AQ_DEPTH)
 		return NVME_RDMA_CM_INVALID_HSQSIZE;
-- 
2.7.4

  parent reply	other threads:[~2016-08-11  4:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11  4:07 [PATCH RFC 0/4] sqsize zero-based fixes Jay Freyensee
2016-08-11  4:07 ` [PATCH RFC 1/4] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-11  9:01   ` Sagi Grimberg
2016-08-11 15:08     ` Christoph Hellwig
2016-08-11 16:33       ` J Freyensee
2016-08-11  4:07 ` [PATCH RFC 2/4] nvme-rdma: fix sqsize/hsqsize/hrqsize " Jay Freyensee
2016-08-11  7:03   ` Sagi Grimberg
2016-08-11 16:35     ` J Freyensee
2016-08-11 15:21   ` Christoph Hellwig
2016-08-11 16:40     ` J Freyensee
2016-08-11 23:24     ` J Freyensee
2016-08-11  4:07 ` Jay Freyensee [this message]
2016-08-11  4:07 ` [PATCH RFC 4/4] nvme-loop: set sqsize to 0-based value, " Jay Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470888438-823-4-git-send-email-james_p_freyensee@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).