From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v2 4/5] nvme-loop: set sqsize to 0-based value, per spec
Date: Tue, 16 Aug 2016 09:22:36 -0700 [thread overview]
Message-ID: <1471364556.21107.8.camel@linux.intel.com> (raw)
In-Reply-To: <4d7c4c72-2f05-dbc8-402d-74593da74814@grimberg.me>
On Tue, 2016-08-16@11:59 +0300, Sagi Grimberg wrote:
>
> On 15/08/16 19:47, Jay Freyensee wrote:
> >
> > Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
> > ---
> > ?drivers/nvme/target/loop.c | 4 ++--
> > ?1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/nvme/target/loop.c
> > b/drivers/nvme/target/loop.c
> > index 94e7829..ce22d4b0 100644
> > --- a/drivers/nvme/target/loop.c
> > +++ b/drivers/nvme/target/loop.c
> > @@ -558,7 +558,7 @@ static int nvme_loop_create_io_queues(struct
> > nvme_loop_ctrl *ctrl)
> >
> > ? memset(&ctrl->tag_set, 0, sizeof(ctrl->tag_set));
> > ? ctrl->tag_set.ops = &nvme_loop_mq_ops;
> > - ctrl->tag_set.queue_depth = ctrl->ctrl.sqsize;
> > + ctrl->tag_set.queue_depth = ctrl->ctrl.sqsize + 1;
>
> Just use opts->queue_size.
OK, will do.
Thanks,
J
next prev parent reply other threads:[~2016-08-16 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 16:47 [PATCH v2 0/5] sqsize fixes Jay Freyensee
2016-08-15 16:47 ` [PATCH v2 1/5] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-16 8:59 ` Sagi Grimberg
2016-08-16 16:19 ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 2/5] nvme-rdma: fix sqsize/hsqsize " Jay Freyensee
2016-08-16 8:57 ` Sagi Grimberg
2016-08-16 16:20 ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-16 8:56 ` Sagi Grimberg
2016-08-16 16:22 ` J Freyensee
2016-08-15 16:47 ` [PATCH v2 4/5] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee
2016-08-16 8:59 ` Sagi Grimberg
2016-08-16 16:22 ` J Freyensee [this message]
2016-08-15 16:47 ` [PATCH v2 5/5] nvme-rdma: adjust hrqsize to plus 1 Jay Freyensee
2016-08-16 9:05 ` Sagi Grimberg
2016-08-16 16:34 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471364556.21107.8.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).