* [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
@ 2016-08-23 10:05 Roy Shterman
2016-08-23 23:42 ` J Freyensee
0 siblings, 1 reply; 5+ messages in thread
From: Roy Shterman @ 2016-08-23 10:05 UTC (permalink / raw)
Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and still
connect to target with nvme-cli tool.
usage examples:
nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q <USER-DEFINED_HOSTNQN>
Signed-off-by: Roy Shterman <roysh at mellanox.com>
---
fabrics.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fabrics.c b/fabrics.c
index 26c4e22..942e987 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char **argv)
"transport address" },
{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid, required_argument,
"transport service id (e.g. IP port)" },
+ {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn, required_argument,
+ "user-defined hostnqn" },
{0},
};
--
1.7.8.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
2016-08-23 10:05 [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command Roy Shterman
@ 2016-08-23 23:42 ` J Freyensee
2016-08-24 6:48 ` Roy Shterman
0 siblings, 1 reply; 5+ messages in thread
From: J Freyensee @ 2016-08-23 23:42 UTC (permalink / raw)
On Tue, 2016-08-23@13:05 +0300, Roy Shterman wrote:
> Added user-defined 'hostnqn' to 'connect' command
> so users could use the allowed_hosts attribute on the target and
> still
> connect to target with nvme-cli tool.
>
> usage examples:
> nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
> <USER-DEFINED_HOSTNQN>
I believe the example needs to be changed from 'discover' to 'connect'
;-)
Jay
>
> Signed-off-by: Roy Shterman <roysh at mellanox.com>
> ---
> ?fabrics.c |????2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fabrics.c b/fabrics.c
> index 26c4e22..942e987 100644
> --- a/fabrics.c
> +++ b/fabrics.c
> @@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
> **argv)
> ? "transport address" },
> ? {"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
> required_argument,
> ? "transport service id (e.g. IP port)" },
> + {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
> required_argument,
> + "user-defined hostnqn" },
> ? {0},
> ? };
> ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
2016-08-23 23:42 ` J Freyensee
@ 2016-08-24 6:48 ` Roy Shterman
0 siblings, 0 replies; 5+ messages in thread
From: Roy Shterman @ 2016-08-24 6:48 UTC (permalink / raw)
On 8/24/2016 2:42 AM, J Freyensee wrote:
> On Tue, 2016-08-23@13:05 +0300, Roy Shterman wrote:
>> Added user-defined 'hostnqn' to 'connect' command
>> so users could use the allowed_hosts attribute on the target and
>> still
>> connect to target with nvme-cli tool.
>>
>> usage examples:
>> nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
>> <USER-DEFINED_HOSTNQN>
> I believe the example needs to be changed from 'discover' to 'connect'
> ;-)
>
> Jay
That's correct, I will sent a new patch :)
>> Signed-off-by: Roy Shterman <roysh at mellanox.com>
>> ---
>> fabrics.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/fabrics.c b/fabrics.c
>> index 26c4e22..942e987 100644
>> --- a/fabrics.c
>> +++ b/fabrics.c
>> @@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
>> **argv)
>> "transport address" },
>> {"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
>> required_argument,
>> "transport service id (e.g. IP port)" },
>> + {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
>> required_argument,
>> + "user-defined hostnqn" },
>> {0},
>> };
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
@ 2016-08-24 6:53 Roy Shterman
2016-08-24 14:58 ` Keith Busch
0 siblings, 1 reply; 5+ messages in thread
From: Roy Shterman @ 2016-08-24 6:53 UTC (permalink / raw)
Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and still
connect to target with nvme-cli tool.
usage examples:
nvme connect -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -n <NQN> -q <USER-DEFINED_HOSTNQN>
Signed-off-by: Roy Shterman <roysh at mellanox.com>
---
fabrics.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fabrics.c b/fabrics.c
index 26c4e22..942e987 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char **argv)
"transport address" },
{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid, required_argument,
"transport service id (e.g. IP port)" },
+ {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn, required_argument,
+ "user-defined hostnqn" },
{0},
};
--
1.7.8.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command
2016-08-24 6:53 Roy Shterman
@ 2016-08-24 14:58 ` Keith Busch
0 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2016-08-24 14:58 UTC (permalink / raw)
On Wed, Aug 24, 2016@09:53:06AM +0300, Roy Shterman wrote:
> Added user-defined 'hostnqn' to 'connect' command
> so users could use the allowed_hosts attribute on the target and still
> connect to target with nvme-cli tool.
>
> usage examples:
> nvme connect -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -n <NQN> -q <USER-DEFINED_HOSTNQN>
>
> Signed-off-by: Roy Shterman <roysh at mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-24 14:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 10:05 [PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command Roy Shterman
2016-08-23 23:42 ` J Freyensee
2016-08-24 6:48 ` Roy Shterman
-- strict thread matches above, loose matches on Subject: below --
2016-08-24 6:53 Roy Shterman
2016-08-24 14:58 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).