linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvme-cli/fabrics: Add nr_io_queues parameter to connect command
Date: Mon, 29 Aug 2016 08:14:31 -0700	[thread overview]
Message-ID: <1472483671.2816.19.camel@linux.intel.com> (raw)
In-Reply-To: <00c301d20206$beb09ab0$3c11d010$@opengridcomputing.com>

On Mon, 2016-08-29@10:05 -0500, Steve Wise wrote:
> > 
> > > 
> > > On Sun, Aug 28, 2016@09:11:42PM -0700, J Freyensee wrote:
> > > > 
> > > > On Fri, 2016-08-26@08:56 -0700, Steve Wise wrote:
> > > > > 
> > > > > Added 'nr_io_queues' to 'connect' command so users can
> > > > > specify the
> > > > > number
> > > > > of io queues to allocate.
> > > > > 
> > > > > usage example:
> > > > > 
> > > > > nvme connect -t rdma -Q 8 -s 4420 -a 10.0.1.14 -n test-nvme
> > > > 
> > > > I was just wondering if there could be another lower-case
> > > > letter flag
> > > > option we could use other than capital Q. ??Just looking at the
> > > > example
> > > > above, it looks a tad out-of-place.
> > > 
> > > -q would be nice. For that'd we need to rename the hostnqn one,
> > > but as
> > > stated before I think -q is really misnamed for that anyway..
> > 
> > -h for hostnqn?
> 
> Oops... -h is 'help' :)

Yep, all the good single letter flags are being taken ;-P.

-i seems fine to me. ?I kind of like -q for hostnqn since hostnqn does
have a 'q' in it so there is somewhat of a mind-remembrance game there
:-).

> 
> 
> 

  parent reply	other threads:[~2016-08-29 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 15:56 [PATCH] nvme-cli/fabrics: Add nr_io_queues parameter to connect command Steve Wise
2016-08-26 21:45 ` Keith Busch
2016-08-29 14:41   ` Steve Wise
2016-08-29  4:11 ` J Freyensee
2016-08-29  8:02   ` Christoph Hellwig
2016-08-29 14:43     ` Steve Wise
2016-08-29 15:05       ` Steve Wise
2016-08-29 15:09         ` Steve Wise
2016-08-29 15:14         ` J Freyensee [this message]
2016-08-29 14:40   ` Steve Wise
2016-08-29 15:13     ` J Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472483671.2816.19.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).