From mboxrd@z Thu Jan 1 00:00:00 1970 From: james_p_freyensee@linux.intel.com (J Freyensee) Date: Fri, 16 Sep 2016 16:33:11 -0700 Subject: [PATCH v3 1/3] nvme/scsi: Remove power management support In-Reply-To: <20160916083333.GB2415@lst.de> References: <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org> <20160916083333.GB2415@lst.de> Message-ID: <1474068791.10494.2.camel@linux.intel.com> On Fri, 2016-09-16@10:33 +0200, Christoph Hellwig wrote: > On Thu, Sep 15, 2016@10:24:19PM -0700, Andy Lutomirski wrote: > > > > As far as I can tell, there is basically nothing correct about this > > code.??It misinterprets npss (off-by-one).??It hardcodes a bunch of > > power states, which is nonsense, because they're all just indices > > into a table that software needs to parse.??It completely ignores > > the distinction between operational and non-operational states. > > And, until 4.8, if all of the above magically succeeded, it would > > dereference a NULL pointer and OOPS. > > > > Since this code appears to be useless, just delete it. > > Yes, please! > > Acked-by: Christoph Hellwig Acked-by: Jay Freyensee