* [PATCH] nvme-rdma: add missing \n to end of dev_err message
@ 2016-09-25 22:01 Colin King
2016-09-26 21:53 ` J Freyensee
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-25 22:01 UTC (permalink / raw)
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_err message is missing a \n, so add it. Also
break line as it was over 80 chars wide.
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
drivers/nvme/host/rdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 69e1fb7..3f32995 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
(struct nvme_rdma_cm_rej *)ev->param.conn.private_data;
dev_err(queue->ctrl->ctrl.device,
- "Connect rejected, status %d.", le16_to_cpu(rej->sts));
+ "Connect rejected, status %d.\n",
+ le16_to_cpu(rej->sts));
/* XXX: Think of something clever to do here... */
} else {
dev_err(queue->ctrl->ctrl.device,
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] nvme-rdma: add missing \n to end of dev_err message
2016-09-25 22:01 [PATCH] nvme-rdma: add missing \n to end of dev_err message Colin King
@ 2016-09-26 21:53 ` J Freyensee
0 siblings, 0 replies; 2+ messages in thread
From: J Freyensee @ 2016-09-26 21:53 UTC (permalink / raw)
On Sun, 2016-09-25@15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
> ---
> ?drivers/nvme/host/rdma.c | 3 ++-
> ?1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
> ? (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
> ?
> ? dev_err(queue->ctrl->ctrl.device,
> - "Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> + "Connect rejected, status %d.\n",
> + le16_to_cpu(rej->sts));
> ? /* XXX: Think of something clever to do here... */
> ? } else {
> ? dev_err(queue->ctrl->ctrl.device,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-26 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-25 22:01 [PATCH] nvme-rdma: add missing \n to end of dev_err message Colin King
2016-09-26 21:53 ` J Freyensee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).