Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvmecli-tests : update the list of dependencies
Date: Thu, 17 Nov 2016 10:56:31 -0800	[thread overview]
Message-ID: <1479408991.3774.7.camel@linux.intel.com> (raw)
In-Reply-To: <CAK0tqinhd3jeasr5+3dtPFB149wREcBwwAw0UrpfNuqpE3Uheg@mail.gmail.com>

On Thu, 2016-11-17@00:48 -0800, chaitany kulkarni wrote:
> README file is updated with complete list of dependencies
> required to setup the environment for unitttests.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at hgst.com>
> ---
> ?tests/README | 13 +++++++++++--
> ?1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/README b/tests/README
> index 70686d8..686bd04 100644
> --- a/tests/README
> +++ b/tests/README
> @@ -12,8 +12,17 @@ nvmetests
> ?------------------------------
> 
> ?????1. Python(>= 2.7.5 or >= 3.3)
> -????2. nose2(Installation guide http://nose2.readthedocs.io/)
> -????3. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
> +????2. nose(http://nose.readthedocs.io/en/latest/)
> +????3. nose2(Installation guide http://nose2.readthedocs.io/)
> +????4. pep8(https://pypi.python.org/pypi/setuptools-pep8)
> +????5. flake8(https://pypi.python.org/pypi/flake8)
> +????6. pylint(https://www.pylint.org/)
> +????7. Epydoc(http://epydoc.sourceforge.net/)
> +????8. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
> +
> +????Python package management system pip can be used to install most
> of the
> +????listed packages(https://pip.pypa.io/en/stable/installing/) :-
> +????$ pip install nose nose2 pep8 flake8 pylint epydoc
> 

Readme looks good, seems to address Keith's point on dependencies.

Though Keith mentioned there was a 'doc' folder referenced in the
README that appeared to be missing from the commit. ?Maybe that is a
future patch?

Reviewed-by: ?Jay Freyensee <james_p_freyensee at linux.intel.com>

  reply	other threads:[~2016-11-17 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  8:48 [PATCH] nvmecli-tests : update the list of dependencies chaitany kulkarni
2016-11-17 18:56 ` J Freyensee [this message]
2016-11-17 19:01   ` chaitany kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479408991.3774.7.camel@linux.intel.com \
    --to=james_p_freyensee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox