* [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper
@ 2016-11-21 20:45 Max Gurtovoy
2016-11-21 20:45 ` [PATCH 2/2] nvme-rdma: " Max Gurtovoy
2016-11-22 7:41 ` [PATCH 1/2] nvmet-rdma: " Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Max Gurtovoy @ 2016-11-21 20:45 UTC (permalink / raw)
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/target/rdma.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 005ef5d..80650e2 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1124,12 +1124,14 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
{
struct nvmet_rdma_queue *queue = priv;
+ pr_err("received IB QP event: %s (%d)\n",
+ ib_event_msg(event->event), event->event);
+
switch (event->event) {
case IB_EVENT_COMM_EST:
rdma_notify(queue->cm_id, event->event);
break;
default:
- pr_err("received unrecognized IB QP event %d\n", event->event);
break;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] nvme-rdma: align to generic ib_event logging helper
2016-11-21 20:45 [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper Max Gurtovoy
@ 2016-11-21 20:45 ` Max Gurtovoy
2016-11-22 7:41 ` Christoph Hellwig
2016-11-22 7:41 ` [PATCH 1/2] nvmet-rdma: " Christoph Hellwig
1 sibling, 1 reply; 5+ messages in thread
From: Max Gurtovoy @ 2016-11-21 20:45 UTC (permalink / raw)
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/host/rdma.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3d25add..bad4ce1 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
static void nvme_rdma_qp_event(struct ib_event *event, void *context)
{
- pr_debug("QP event %d\n", event->event);
+ pr_err("QP event %s (%d)\n",
+ ib_event_msg(event->event), event->event);
+
}
static int nvme_rdma_wait_for_cm(struct nvme_rdma_queue *queue)
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-21 20:45 [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper Max Gurtovoy
2016-11-21 20:45 ` [PATCH 2/2] nvme-rdma: " Max Gurtovoy
@ 2016-11-22 7:41 ` Christoph Hellwig
2016-11-22 14:00 ` Max Gurtovoy
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2016-11-22 7:41 UTC (permalink / raw)
On Mon, Nov 21, 2016@10:45:44PM +0200, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> drivers/nvme/target/rdma.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 005ef5d..80650e2 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1124,12 +1124,14 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
> {
> struct nvmet_rdma_queue *queue = priv;
>
> + pr_err("received IB QP event: %s (%d)\n",
> + ib_event_msg(event->event), event->event);
> +
> switch (event->event) {
> case IB_EVENT_COMM_EST:
> rdma_notify(queue->cm_id, event->event);
> break;
> default:
> - pr_err("received unrecognized IB QP event %d\n", event->event);
> break;
This will print an error message every time a connection is established.
Either tune it down to pr_debug or keep it inside the default case.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] nvme-rdma: align to generic ib_event logging helper
2016-11-21 20:45 ` [PATCH 2/2] nvme-rdma: " Max Gurtovoy
@ 2016-11-22 7:41 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2016-11-22 7:41 UTC (permalink / raw)
On Mon, Nov 21, 2016@10:45:45PM +0200, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> drivers/nvme/host/rdma.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 3d25add..bad4ce1 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
>
> static void nvme_rdma_qp_event(struct ib_event *event, void *context)
> {
> - pr_debug("QP event %d\n", event->event);
> + pr_err("QP event %s (%d)\n",
> + ib_event_msg(event->event), event->event);
> +
> }
Why not keep the pr_debug?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-22 7:41 ` [PATCH 1/2] nvmet-rdma: " Christoph Hellwig
@ 2016-11-22 14:00 ` Max Gurtovoy
0 siblings, 0 replies; 5+ messages in thread
From: Max Gurtovoy @ 2016-11-22 14:00 UTC (permalink / raw)
On 11/22/2016 9:41 AM, Christoph Hellwig wrote:
> On Mon, Nov 21, 2016@10:45:44PM +0200, Max Gurtovoy wrote:
>> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
>> ---
>> drivers/nvme/target/rdma.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
>> index 005ef5d..80650e2 100644
>> --- a/drivers/nvme/target/rdma.c
>> +++ b/drivers/nvme/target/rdma.c
>> @@ -1124,12 +1124,14 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
>> {
>> struct nvmet_rdma_queue *queue = priv;
>>
>> + pr_err("received IB QP event: %s (%d)\n",
>> + ib_event_msg(event->event), event->event);
>> +
>> switch (event->event) {
>> case IB_EVENT_COMM_EST:
>> rdma_notify(queue->cm_id, event->event);
>> break;
>> default:
>> - pr_err("received unrecognized IB QP event %d\n", event->event);
>> break;
>
> This will print an error message every time a connection is established.
> Either tune it down to pr_debug or keep it inside the default case.
I haven't seen this event message on connection establishment and this
is the debug level we use in iser/isert parrallel function.
But I'll tune it to pr_debug if needed, no problem.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-22 14:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 20:45 [PATCH 1/2] nvmet-rdma: align to generic ib_event logging helper Max Gurtovoy
2016-11-21 20:45 ` [PATCH 2/2] nvme-rdma: " Max Gurtovoy
2016-11-22 7:41 ` Christoph Hellwig
2016-11-22 7:41 ` [PATCH 1/2] nvmet-rdma: " Christoph Hellwig
2016-11-22 14:00 ` Max Gurtovoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).