[PATCH v2 0/2] align to generic ib_event logging helper

[PATCH v2 0/2] align to generic ib_event logging helper

[Max Gurtovoy]

Changes since V1:
  - updated debug level to pr_debug

Max Gurtovoy (2):
  nvmet-rdma: align to generic ib_event logging helper
  nvme-rdma: align to generic ib_event logging helper

 drivers/nvme/host/rdma.c   |    4 +++-
 drivers/nvme/target/rdma.c |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

[PATCH v2 1/2] nvmet-rdma: align to generic ib_event logging helper

[Max Gurtovoy]

Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/target/rdma.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 005ef5d..7a07e66 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1124,12 +1124,14 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
 {
 	struct nvmet_rdma_queue *queue = priv;
 
+	pr_debug("received IB QP event: %s (%d)\n",
+		 ib_event_msg(event->event), event->event);
+
 	switch (event->event) {
 	case IB_EVENT_COMM_EST:
 		rdma_notify(queue->cm_id, event->event);
 		break;
 	default:
-		pr_err("received unrecognized IB QP event %d\n", event->event);
 		break;
 	}
 }
-- 
1.7.1

[PATCH v2 1/2] nvmet-rdma: align to generic ib_event logging helper

[Christoph Hellwig]

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

[PATCH v2 2/2] nvme-rdma: align to generic ib_event logging helper

[Max Gurtovoy]

Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/host/rdma.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3d25add..9c34da5 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
 
 static void nvme_rdma_qp_event(struct ib_event *event, void *context)
 {
-	pr_debug("QP event %d\n", event->event);
+	pr_debug("QP event %s (%d)\n",
+		 ib_event_msg(event->event), event->event);
+
 }
 
 static int nvme_rdma_wait_for_cm(struct nvme_rdma_queue *queue)
-- 
1.7.1

[PATCH v2 2/2] nvme-rdma: align to generic ib_event logging helper

[Max Gurtovoy]

sorry, but I don't know why it send the patch-set twice.

On 11/22/2016 4:36 PM, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
>  drivers/nvme/host/rdma.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 3d25add..9c34da5 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
>
>  static void nvme_rdma_qp_event(struct ib_event *event, void *context)
>  {
> -	pr_debug("QP event %d\n", event->event);
> +	pr_debug("QP event %s (%d)\n",
> +		 ib_event_msg(event->event), event->event);
> +
>  }
>
>  static int nvme_rdma_wait_for_cm(struct nvme_rdma_queue *queue)
>

[PATCH v2 2/2] nvme-rdma: align to generic ib_event logging helper

[Christoph Hellwig]

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

[PATCH v2 0/2] align to generic ib_event logging helper

[J Freyensee]

On Tue, 2016-11-22@16:36 +0200, Max Gurtovoy wrote:
> Changes since V1:
> ? - updated debug level to pr_debug
> 
> Max Gurtovoy (2):
> ? nvmet-rdma: align to generic ib_event logging helper
> ? nvme-rdma: align to generic ib_event logging helper
> 
> ?drivers/nvme/host/rdma.c???|????4 +++-
> ?drivers/nvme/target/rdma.c |????4 +++-
> ?2 files changed, 6 insertions(+), 2 deletions(-)

Seems fine but I'm curious why the extra debugging is needed to the
point it warrants a change to the Linux kernel? ?Why does the default
print case need to be moved such that there will be a debug message
printed for each event instead of the unmatched default event?

> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

[PATCH v2 0/2] align to generic ib_event logging helper

[Max Gurtovoy]

On 11/22/2016 6:23 PM, J Freyensee wrote:
> On Tue, 2016-11-22@16:36 +0200, Max Gurtovoy wrote:
>> Changes since V1:
>>   - updated debug level to pr_debug
>>
>> Max Gurtovoy (2):
>>   nvmet-rdma: align to generic ib_event logging helper
>>   nvme-rdma: align to generic ib_event logging helper
>>
>>  drivers/nvme/host/rdma.c   |    4 +++-
>>  drivers/nvme/target/rdma.c |    4 +++-
>>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> Seems fine but I'm curious why the extra debugging is needed to the
> point it warrants a change to the Linux kernel?  Why does the default
> print case need to be moved such that there will be a debug message
> printed for each event instead of the unmatched default event?

The reason for this commit is to use generic ib_event_msg (that is used 
in iser/srp/isert etc...). I'll add a new version that will keep it 
inside the default case in the target side.

>
>>
>>
>> _______________________________________________
>> Linux-nvme mailing list
>> Linux-nvme at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-nvme