* [PATCH v3 0/2] align to generic ib_event logging helper
@ 2016-11-23 9:38 Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Max Gurtovoy @ 2016-11-23 9:38 UTC (permalink / raw)
Changes since V2:
- keep log prints inside the default case for nvmet-rdma
Max Gurtovoy (2):
nvmet-rdma: align to generic ib_event logging helper
nvme-rdma: align to generic ib_event logging helper
drivers/nvme/host/rdma.c | 4 +++-
drivers/nvme/target/rdma.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-23 9:38 [PATCH v3 0/2] align to generic ib_event logging helper Max Gurtovoy
@ 2016-11-23 9:38 ` Max Gurtovoy
2016-11-23 18:25 ` J Freyensee
2016-11-23 9:38 ` [PATCH v3 2/2] nvme-rdma: " Max Gurtovoy
2016-12-02 13:56 ` [PATCH v3 0/2] " Christoph Hellwig
2 siblings, 1 reply; 9+ messages in thread
From: Max Gurtovoy @ 2016-11-23 9:38 UTC (permalink / raw)
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/target/rdma.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 005ef5d..ddbae24 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
rdma_notify(queue->cm_id, event->event);
break;
default:
- pr_err("received unrecognized IB QP event %d\n", event->event);
+ pr_err("received IB QP event: %s (%d)\n",
+ ib_event_msg(event->event), event->event);
break;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
@ 2016-11-23 18:25 ` J Freyensee
2016-11-24 11:19 ` Max Gurtovoy
0 siblings, 1 reply; 9+ messages in thread
From: J Freyensee @ 2016-11-23 18:25 UTC (permalink / raw)
On Wed, 2016-11-23@11:38 +0200, Max Gurtovoy wrote:
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> ---
> ?drivers/nvme/target/rdma.c |????3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index 005ef5d..ddbae24 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event
> *event, void *priv)
> ? rdma_notify(queue->cm_id, event->event);
> ? break;
> ? default:
> - pr_err("received unrecognized IB QP event %d\n",
> event->event);
> + pr_err("received IB QP event: %s (%d)\n",
> + ???????ib_event_msg(event->event), event->event);
I liked the original print statement mentioning something that it hit
the default case ("received unrecognized IB QP event"). ?But if no one
else has a problem with it, then I'm ok with it.
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-23 18:25 ` J Freyensee
@ 2016-11-24 11:19 ` Max Gurtovoy
2016-11-25 7:48 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: Max Gurtovoy @ 2016-11-24 11:19 UTC (permalink / raw)
On 11/23/2016 8:25 PM, J Freyensee wrote:
> On Wed, 2016-11-23@11:38 +0200, Max Gurtovoy wrote:
>> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
>> ---
>> drivers/nvme/target/rdma.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
>> index 005ef5d..ddbae24 100644
>> --- a/drivers/nvme/target/rdma.c
>> +++ b/drivers/nvme/target/rdma.c
>> @@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event
>> *event, void *priv)
>> rdma_notify(queue->cm_id, event->event);
>> break;
>> default:
>> - pr_err("received unrecognized IB QP event %d\n",
>> event->event);
>> + pr_err("received IB QP event: %s (%d)\n",
>> + ib_event_msg(event->event), event->event);
>
> I liked the original print statement mentioning something that it hit
> the default case ("received unrecognized IB QP event"). But if no one
> else has a problem with it, then I'm ok with it.
in that case you'll get something like:
"nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"
instead of
"nvmet_rdma: received IB QP event: last WQE reached (16)"
Sagi/Christoph, what do you think ?
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-24 11:19 ` Max Gurtovoy
@ 2016-11-25 7:48 ` Christoph Hellwig
2016-11-27 9:28 ` Max Gurtovoy
0 siblings, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2016-11-25 7:48 UTC (permalink / raw)
On Thu, Nov 24, 2016@01:19:11PM +0200, Max Gurtovoy wrote:
> in that case you'll get something like:
>
> "nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"
>
> instead of
>
> "nvmet_rdma: received IB QP event: last WQE reached (16)"
>
> Sagi/Christoph, what do you think ?
I don't care, it's only a debug printk anyway.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 1/2] nvmet-rdma: align to generic ib_event logging helper
2016-11-25 7:48 ` Christoph Hellwig
@ 2016-11-27 9:28 ` Max Gurtovoy
0 siblings, 0 replies; 9+ messages in thread
From: Max Gurtovoy @ 2016-11-27 9:28 UTC (permalink / raw)
On 11/25/2016 9:48 AM, Christoph Hellwig wrote:
> On Thu, Nov 24, 2016@01:19:11PM +0200, Max Gurtovoy wrote:
>> in that case you'll get something like:
>>
>> "nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"
>>
>> instead of
>>
>> "nvmet_rdma: received IB QP event: last WQE reached (16)"
>>
>> Sagi/Christoph, what do you think ?
>
> I don't care, it's only a debug printk anyway.
>
me too :) I just want to put this 2 patches behind us.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 2/2] nvme-rdma: align to generic ib_event logging helper
2016-11-23 9:38 [PATCH v3 0/2] align to generic ib_event logging helper Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
@ 2016-11-23 9:38 ` Max Gurtovoy
2016-11-23 18:23 ` J Freyensee
2016-12-02 13:56 ` [PATCH v3 0/2] " Christoph Hellwig
2 siblings, 1 reply; 9+ messages in thread
From: Max Gurtovoy @ 2016-11-23 9:38 UTC (permalink / raw)
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/host/rdma.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3d25add..9c34da5 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
static void nvme_rdma_qp_event(struct ib_event *event, void *context)
{
- pr_debug("QP event %d\n", event->event);
+ pr_debug("QP event %s (%d)\n",
+ ib_event_msg(event->event), event->event);
+
}
static int nvme_rdma_wait_for_cm(struct nvme_rdma_queue *queue)
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 0/2] align to generic ib_event logging helper
2016-11-23 9:38 [PATCH v3 0/2] align to generic ib_event logging helper Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 2/2] nvme-rdma: " Max Gurtovoy
@ 2016-12-02 13:56 ` Christoph Hellwig
2 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2016-12-02 13:56 UTC (permalink / raw)
Thanks Max,
I've applied the series to the nvmf-4.10 branch.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-12-02 13:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 9:38 [PATCH v3 0/2] align to generic ib_event logging helper Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 1/2] nvmet-rdma: " Max Gurtovoy
2016-11-23 18:25 ` J Freyensee
2016-11-24 11:19 ` Max Gurtovoy
2016-11-25 7:48 ` Christoph Hellwig
2016-11-27 9:28 ` Max Gurtovoy
2016-11-23 9:38 ` [PATCH v3 2/2] nvme-rdma: " Max Gurtovoy
2016-11-23 18:23 ` J Freyensee
2016-12-02 13:56 ` [PATCH v3 0/2] " Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).