From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 3/3] nvme: Make controller state visible via sysfs
Date: Mon, 5 Dec 2016 13:09:06 +0200 [thread overview]
Message-ID: <1480936146-6406-4-git-send-email-sagi@grimberg.me> (raw)
In-Reply-To: <1480936146-6406-1-git-send-email-sagi@grimberg.me>
Easier for debugging and testing state machine
transitions.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/core.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a37cb215652b..c5b8f7b56042 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1569,6 +1569,26 @@ static ssize_t nvme_sysfs_show_transport(struct device *dev,
}
static DEVICE_ATTR(transport, S_IRUGO, nvme_sysfs_show_transport, NULL);
+static ssize_t nvme_sysfs_show_state(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
+ static const char *const state_name[] = {
+ [NVME_CTRL_NEW] = "new",
+ [NVME_CTRL_LIVE] = "live",
+ [NVME_CTRL_RESETTING] = "resetting",
+ [NVME_CTRL_RECONNECTING]= "reconnecting",
+ [NVME_CTRL_DELETING] = "deleting",
+ [NVME_CTRL_DEAD] = "dead",
+ };
+
+ return sprintf(buf, "%s\n",
+ (unsigned)ctrl->state < ARRAY_SIZE(state_name) ?
+ state_name[ctrl->state] : "???");
+}
+static DEVICE_ATTR(state, S_IRUGO, nvme_sysfs_show_state, NULL);
+
static ssize_t nvme_sysfs_show_subsysnqn(struct device *dev,
struct device_attribute *attr,
char *buf)
@@ -1601,6 +1621,7 @@ static struct attribute *nvme_dev_attrs[] = {
&dev_attr_transport.attr,
&dev_attr_subsysnqn.attr,
&dev_attr_address.attr,
+ &dev_attr_state.attr,
NULL
};
--
2.7.4
next prev parent reply other threads:[~2016-12-05 11:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 11:09 [PATCH 0/3] some useful fabrics patches Sagi Grimberg
2016-12-05 11:09 ` [PATCH 1/3] nvmet: delete controllers deletion upon subsystem release Sagi Grimberg
2016-12-05 11:39 ` Johannes Thumshirn
2016-12-05 14:08 ` Max Gurtovoy
2016-12-05 15:40 ` Christoph Hellwig
2016-12-05 17:08 ` Sagi Grimberg
2016-12-06 8:28 ` Christoph Hellwig
2016-12-05 11:09 ` [PATCH 2/3] nvmet: Make cntlid globally unique Sagi Grimberg
2016-12-05 11:38 ` Johannes Thumshirn
2016-12-05 14:08 ` Max Gurtovoy
2016-12-05 15:34 ` Christoph Hellwig
2016-12-05 17:06 ` Sagi Grimberg
2016-12-06 8:28 ` Christoph Hellwig
2016-12-06 23:23 ` J Freyensee
2016-12-05 11:09 ` Sagi Grimberg [this message]
2016-12-05 11:37 ` [PATCH 3/3] nvme: Make controller state visible via sysfs Johannes Thumshirn
2016-12-05 14:15 ` Max Gurtovoy
2016-12-05 17:05 ` Sagi Grimberg
2016-12-05 15:37 ` Christoph Hellwig
2016-12-05 17:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480936146-6406-4-git-send-email-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).