From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v2] nvmet: discovery controller to set ioccsz and iorcsz
Date: Tue, 21 Feb 2017 12:41:39 -0800 [thread overview]
Message-ID: <1487709699.3502.24.camel@linux.intel.com> (raw)
In-Reply-To: <20170217091532.GA16652@infradead.org>
On Fri, 2017-02-17@01:15 -0800, Christoph Hellwig wrote:
> On Thu, Feb 16, 2017@06:42:20PM -0800, James Smart wrote:
> >
> >
> > Revised the patch: add transport capsule inline size into ioccsz value
> >
> > The discovery controller's Identify command handler never set these
> > fields leaving them zero. The host-side fc transport validates that
> > these values are appropriate and was killing the connection with the
> > controller as they were zero.
> >
> > Set the controller ioccsz and iorcsz values
>
> Discovery controllers do not support I/O commands, so these settings
> don't make any sense there.??They are also not included in the
> fields that Idenitfy Controller should report for Discovery controllers
> (Figure 33 in Fabrics 1.0)
I didn't think it hurt making sure these two fields contain the minimum
required values, per Fabrics spec, as values of 0 are invalid (Figure 28). ?But
I also see your point.
Jay
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2017-02-21 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 2:42 [PATCH v2] nvmet: discovery controller to set ioccsz and iorcsz James Smart
2017-02-17 9:15 ` Christoph Hellwig
2017-02-21 20:41 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487709699.3502.24.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox