From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v2] fabrics: Handle space-padded TRSVCID and TRADDR fields
Date: Mon, 06 Mar 2017 11:49:46 -0800 [thread overview]
Message-ID: <1488829786.3733.8.camel@linux.intel.com> (raw)
In-Reply-To: <20170306193621.11190-1-roland@kernel.org>
On Mon, 2017-03-06@11:36 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland at purestorage.com>
>
> The TRSVCID and TRADDR fields in the discovery log page are defined
> as ASCII strings, which according to the NVMe standard means they
> should be space-padded rather than NUL-terminated.
>
> The current nvme-cli code will print all the spaces and possibly some
> garbage from the next field.??For example this causes "connect-all"
> to write strings that get rejected with "malformed IP address passed."
>
> Fix this by only writing the contents of these fields until the last
> non-space character, and limiting the length to the size of the field.
>
> Signed-off-by: Roland Dreier <roland at purestorage.com>
Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
(already pulled into nvme-cli by Keith).
prev parent reply other threads:[~2017-03-06 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 19:36 [PATCH v2] fabrics: Handle space-padded TRSVCID and TRADDR fields Roland Dreier
2017-03-06 19:49 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488829786.3733.8.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).