From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 2/2] nvme-loop: fix module_init (theoretical) error path
Date: Sun, 19 Mar 2017 06:29:12 +0200 [thread overview]
Message-ID: <1489897752-16691-2-git-send-email-sagi@grimberg.me> (raw)
In-Reply-To: <1489897752-16691-1-git-send-email-sagi@grimberg.me>
if nvmf_register_transport happend to fail, we
need to nvmet_unregister_transport as well.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/target/loop.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 22f7bc6bac7f..7053676aa87f 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -736,7 +736,12 @@ static int __init nvme_loop_init_module(void)
ret = nvmet_register_transport(&nvme_loop_ops);
if (ret)
return ret;
- return nvmf_register_transport(&nvme_loop_transport);
+
+ ret = nvmf_register_transport(&nvme_loop_transport);
+ if (ret)
+ nvmet_unregister_transport(&nvme_loop_ops);
+
+ return ret;
}
static void __exit nvme_loop_cleanup_module(void)
--
2.7.4
next prev parent reply other threads:[~2017-03-19 4:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 4:29 [PATCH 1/2] nvme-rdma: fix module_init (theoretical) error path Sagi Grimberg
2017-03-19 4:29 ` Sagi Grimberg [this message]
2017-03-21 13:44 ` [PATCH 2/2] nvme-loop: " Johannes Thumshirn
2017-03-27 9:51 ` Christoph Hellwig
2017-03-21 13:43 ` [PATCH 1/2] nvme-rdma: " Johannes Thumshirn
2017-03-27 9:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489897752-16691-2-git-send-email-sagi@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).