From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH v2 3/4] nvme: enable SG gaps support
Date: Thu, 13 Apr 2017 18:56:16 +0300 [thread overview]
Message-ID: <1492098977-5231-4-git-send-email-maxg@mellanox.com> (raw)
In-Reply-To: <1492098977-5231-1-git-send-email-maxg@mellanox.com>
For controllers that can handle arbitrarily sized bios (e.g advanced
RDMA ctrls) we can allow the block layer to pass us gaps by skip
setting the queue virt_boundary.
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
Reviewed-by: Keith Busch <keith.busch at intel.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Leon Romanovsky <leon at kernel.org>
---
drivers/nvme/host/core.c | 5 ++++-
drivers/nvme/host/nvme.h | 1 +
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9583a5f..72bc70e 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1252,7 +1252,10 @@ static void nvme_set_queue_limits(struct nvme_ctrl *ctrl,
}
if (ctrl->quirks & NVME_QUIRK_STRIPE_SIZE)
blk_queue_chunk_sectors(q, ctrl->max_hw_sectors);
- blk_queue_virt_boundary(q, ctrl->page_size - 1);
+
+ if (!ctrl->sg_gaps_support)
+ blk_queue_virt_boundary(q, ctrl->page_size - 1);
+
if (ctrl->vwc & NVME_CTRL_VWC_PRESENT)
vwc = true;
blk_queue_write_cache(q, vwc, vwc);
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 2aa20e3..ccb895a 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -162,6 +162,7 @@ struct nvme_ctrl {
struct work_struct scan_work;
struct work_struct async_event_work;
struct delayed_work ka_work;
+ bool sg_gaps_support;
/* Power saving configuration */
u64 ps_max_latency_us;
--
1.7.1
next prev parent reply other threads:[~2017-04-13 15:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 15:56 [PATCH v2 0/4] arbitrary sg lists support Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 1/4] IB/core: Add inline function to get sg mr type Max Gurtovoy
2017-04-20 11:24 ` Sagi Grimberg
2017-04-13 15:56 ` [PATCH v2 2/4] IB/iser: Use ib_get_sg_mr_type() helper Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy [this message]
2017-04-20 11:27 ` [PATCH v2 3/4] nvme: enable SG gaps support Sagi Grimberg
2017-04-21 6:44 ` Christoph Hellwig
2017-04-23 7:20 ` Sagi Grimberg
2017-04-23 8:45 ` Christoph Hellwig
2017-04-23 9:45 ` Sagi Grimberg
2017-04-23 13:23 ` Max Gurtovoy
2017-04-24 7:02 ` Christoph Hellwig
2017-04-13 15:56 ` [PATCH v2 4/4] nvme-rdma: add support for arbitrary sg lists mapping Max Gurtovoy
2017-04-13 16:31 ` [PATCH v2 0/4] arbitrary sg lists support Bart Van Assche
2017-04-13 16:46 ` Max Gurtovoy
2017-04-13 16:59 ` Laurence Oberman
2017-04-20 11:30 ` Sagi Grimberg
2017-04-23 10:34 ` Leon Romanovsky
2017-04-23 11:49 ` Sagi Grimberg
2017-04-23 12:12 ` Leon Romanovsky
2017-04-23 12:28 ` Sagi Grimberg
2017-04-23 13:35 ` Max Gurtovoy
2017-04-23 14:35 ` Sagi Grimberg
2017-05-01 18:50 ` Doug Ledford
2017-05-02 16:14 ` Max Gurtovoy
2017-05-02 16:39 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492098977-5231-4-git-send-email-maxg@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).