From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH v2 4/4] nvme-rdma: add support for arbitrary sg lists mapping
Date: Thu, 13 Apr 2017 18:56:17 +0300 [thread overview]
Message-ID: <1492098977-5231-5-git-send-email-maxg@mellanox.com> (raw)
In-Reply-To: <1492098977-5231-1-git-send-email-maxg@mellanox.com>
If the device support arbitrary sg list mapping (device
cap IB_DEVICE_SG_GAPS_REG set) we allocate the memory regions with
IB_MR_TYPE_SG_GAPS and allow the block layer to send us gappy bio
vectors. We use this functionality in iSER driver as well.
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
Reviewed-by: Leon Romanovsky <leon at kernel.org>
---
drivers/nvme/host/rdma.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 47a479f..1c6f974 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -294,8 +294,8 @@ static int nvme_rdma_reinit_request(void *data, struct request *rq)
ib_dereg_mr(req->mr);
- req->mr = ib_alloc_mr(dev->pd, IB_MR_TYPE_MEM_REG,
- ctrl->max_fr_pages);
+ req->mr = ib_alloc_mr(dev->pd, ib_get_sg_mr_type(dev->dev),
+ ctrl->max_fr_pages);
if (IS_ERR(req->mr)) {
ret = PTR_ERR(req->mr);
req->mr = NULL;
@@ -348,8 +348,8 @@ static int __nvme_rdma_init_request(struct nvme_rdma_ctrl *ctrl,
if (ret)
return ret;
- req->mr = ib_alloc_mr(dev->pd, IB_MR_TYPE_MEM_REG,
- ctrl->max_fr_pages);
+ req->mr = ib_alloc_mr(dev->pd, ib_get_sg_mr_type(ibdev),
+ ctrl->max_fr_pages);
if (IS_ERR(req->mr)) {
ret = PTR_ERR(req->mr);
goto out_free_qe;
@@ -1608,6 +1608,9 @@ static int nvme_rdma_configure_admin_queue(struct nvme_rdma_ctrl *ctrl)
ctrl->ctrl.sqsize =
min_t(int, NVME_CAP_MQES(ctrl->cap) + 1, ctrl->ctrl.sqsize);
+ if (ctrl->device->dev->attrs.device_cap_flags & IB_DEVICE_SG_GAPS_REG)
+ ctrl->ctrl.sg_gaps_support = true;
+
error = nvme_enable_ctrl(&ctrl->ctrl, ctrl->cap);
if (error)
goto out_cleanup_queue;
--
1.7.1
next prev parent reply other threads:[~2017-04-13 15:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 15:56 [PATCH v2 0/4] arbitrary sg lists support Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 1/4] IB/core: Add inline function to get sg mr type Max Gurtovoy
2017-04-20 11:24 ` Sagi Grimberg
2017-04-13 15:56 ` [PATCH v2 2/4] IB/iser: Use ib_get_sg_mr_type() helper Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 3/4] nvme: enable SG gaps support Max Gurtovoy
2017-04-20 11:27 ` Sagi Grimberg
2017-04-21 6:44 ` Christoph Hellwig
2017-04-23 7:20 ` Sagi Grimberg
2017-04-23 8:45 ` Christoph Hellwig
2017-04-23 9:45 ` Sagi Grimberg
2017-04-23 13:23 ` Max Gurtovoy
2017-04-24 7:02 ` Christoph Hellwig
2017-04-13 15:56 ` Max Gurtovoy [this message]
2017-04-13 16:31 ` [PATCH v2 0/4] arbitrary sg lists support Bart Van Assche
2017-04-13 16:46 ` Max Gurtovoy
2017-04-13 16:59 ` Laurence Oberman
2017-04-20 11:30 ` Sagi Grimberg
2017-04-23 10:34 ` Leon Romanovsky
2017-04-23 11:49 ` Sagi Grimberg
2017-04-23 12:12 ` Leon Romanovsky
2017-04-23 12:28 ` Sagi Grimberg
2017-04-23 13:35 ` Max Gurtovoy
2017-04-23 14:35 ` Sagi Grimberg
2017-05-01 18:50 ` Doug Ledford
2017-05-02 16:14 ` Max Gurtovoy
2017-05-02 16:39 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492098977-5231-5-git-send-email-maxg@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).