From: mwilck@suse.de (Martin Wilck)
Subject: [dm-devel] [PATCH 1/4] libmultipath: get_udev_uid: make sure pp->wwid is 0-terminated
Date: Fri, 14 Jul 2017 23:21:20 +0200 [thread overview]
Message-ID: <1500067280.4808.27.camel@suse.de> (raw)
In-Reply-To: <1500063703.2662.9.camel@wdc.com>
On Fri, 2017-07-14@20:21 +0000, Bart Van Assche wrote:
> On Fri, 2017-07-14@21:21 +0200, Martin Wilck wrote:
> >
> > Let's have a strncpy vs. strlcpy discussion :D !
> >
> > I can do this if you insist, but I don't see a big benefit. We've
> > tested with the patch I submitted.
>
> My comments were not intended as an invitation to open a strncpy()
> vs. strlcpy()
> discussion. What I wanted to illustrate with the above patch is that
> when using
> strlcpy() it is not necessary to explicitly zero-terminate a string
> because
> strlcpy() guarantees zero-termination. Compact code that is as
> readable as more
> verbose code is always better because compact code is easier to
> verify.
OK. I'll wait for comments on the other patches, and change v2 of this
patch to your version.
Martin
next prev parent reply other threads:[~2017-07-14 21:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 11:32 [PATCH 0/4] libmultipath: Fixes for NVME / NVMEoF Martin Wilck
2017-07-14 11:32 ` [PATCH 1/4] libmultipath: get_udev_uid: make sure pp->wwid is 0-terminated Martin Wilck
2017-07-14 14:56 ` [dm-devel] " Bart Van Assche
2017-07-14 19:21 ` Martin Wilck
2017-07-14 20:21 ` Bart Van Assche
2017-07-14 21:21 ` Martin Wilck [this message]
2017-07-14 21:27 ` Bart Van Assche
2017-07-14 22:17 ` Benjamin Marzinski
2017-07-14 11:32 ` [PATCH 2/4] libmultipath: drop uevent_can_discard_by_devpath Martin Wilck
2017-07-14 22:18 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 3/4] libmultipath: only listen for uevents with DEVTYPE=disk Martin Wilck
2017-07-14 22:16 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 4/4] libmultipath: fix over-long NVME WWIDs Martin Wilck
2017-07-14 22:38 ` Benjamin Marzinski
2017-07-17 1:13 ` Guan Junxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500067280.4808.27.camel@suse.de \
--to=mwilck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox