Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2 2/4] nvme/pci: Use req_op to determine DIF remapping
Date: Tue, 29 Aug 2017 17:46:02 -0400	[thread overview]
Message-ID: <1504043164-5398-3-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1504043164-5398-1-git-send-email-keith.busch@intel.com>

Only read and write commands need DIF remapping. Everything else uses
a passthrough integrity payload.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 925467b..75c0007 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -666,7 +666,7 @@ static blk_status_t nvme_map_data(struct nvme_dev *dev, struct request *req,
 		if (blk_rq_map_integrity_sg(q, req->bio, &iod->meta_sg) != 1)
 			goto out_unmap;
 
-		if (rq_data_dir(req))
+		if (req_op(req) == REQ_OP_WRITE)
 			nvme_dif_remap(req, nvme_dif_prep);
 
 		if (!dma_map_sg(dev->dev, &iod->meta_sg, 1, dma_dir))
@@ -694,7 +694,7 @@ static void nvme_unmap_data(struct nvme_dev *dev, struct request *req)
 	if (iod->nents) {
 		dma_unmap_sg(dev->dev, iod->sg, iod->nents, dma_dir);
 		if (blk_integrity_rq(req)) {
-			if (!rq_data_dir(req))
+			if (req_op(req) == REQ_OP_READ)
 				nvme_dif_remap(req, nvme_dif_complete);
 			dma_unmap_sg(dev->dev, &iod->meta_sg, 1, dma_dir);
 		}
-- 
2.5.5

  parent reply	other threads:[~2017-08-29 21:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 21:46 [PATCHv2 0/4] nvme user metadata updates Keith Busch
2017-08-29 21:46 ` [PATCHv2 1/4] nvme: factor metadata handling out of __nvme_submit_user_cmd Keith Busch
2017-08-29 22:20   ` Max Gurtovoy
2017-08-29 22:39     ` Keith Busch
2017-08-30  8:14     ` Christoph Hellwig
2017-08-29 21:46 ` Keith Busch [this message]
2017-08-29 22:29   ` [PATCHv2 2/4] nvme/pci: Use req_op to determine DIF remapping Max Gurtovoy
2017-08-30  8:15   ` Christoph Hellwig
2017-08-29 21:46 ` [PATCHv2 3/4] nvme: Make nvme user functions static Keith Busch
2017-08-29 22:30   ` Max Gurtovoy
2017-08-29 21:46 ` [PATCHv2 4/4] nvme: Use metadata for passthrough commands Keith Busch
2017-08-29 22:31   ` Max Gurtovoy
2017-08-30  8:15 ` [PATCHv2 0/4] nvme user metadata updates Christoph Hellwig
2017-08-30 10:06 ` Sagi Grimberg
2017-08-30 12:53 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504043164-5398-3-git-send-email-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox