From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@kernel.org>, Joel Granados <j.granados@samsung.com>
Cc: "hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"gost.dev@samsung.com" <gost.dev@samsung.com>
Subject: Re: [PATCH v3 1/1] nvme : Add ioctl to query nvme attributes
Date: Sat, 19 Nov 2022 00:04:43 +0000 [thread overview]
Message-ID: <150ffa65-3798-3f8c-8594-e8b29f7511be@nvidia.com> (raw)
In-Reply-To: <Y3gIl1d8tVsx/+NG@kbusch-mbp.dhcp.thefacebook.com>
On 11/18/22 14:35, Keith Busch wrote:
> On Thu, Nov 17, 2022 at 03:13:37PM +0100, Joel Granados wrote:
>> +#define NVME_IOCTL_GET_ATTR _IOWR('N', 0x50, struct nvme_get_attr)
>
> Isn't the ioctl's number derived from the sizeof the parameter? IOW, if
> you add new fields to the struct in the future, the ioctl number will
> change, breaking older applications that were using it. I don't think we
> want to keep adding new ioctl's to support legacy users, so probably
> padding that struct with plenty of reserved space is the way to go.
This is exactly I've asked explicitly to make the size of the structure
close to nvme command size (or even better to nvme identify controller
data structure size) so it will be future proof and we can add new
parameters.
Instead the rsvd field seems to be removed in this patch.
-ck
next prev parent reply other threads:[~2022-11-19 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221117141717eucas1p22722572ae0898b65a872658d5a4ef14e@eucas1p2.samsung.com>
2022-11-17 14:13 ` [PATCH v3 0/1] nvme : Add ioctl to query nvme device attributes Joel Granados
2022-11-17 14:13 ` [PATCH v3 1/1] nvme : Add ioctl to query nvme attributes Joel Granados
2022-11-18 22:35 ` Keith Busch
2022-11-19 0:04 ` Chaitanya Kulkarni [this message]
2022-11-21 15:54 ` Joel Granados
2022-11-21 15:51 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150ffa65-3798-3f8c-8594-e8b29f7511be@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=j.granados@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox