Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bart.VanAssche@wdc.com (Bart Van Assche)
Subject: [PATCH 1/4] IB/core: add support for draining Shared receive queues
Date: Thu, 18 Jan 2018 18:06:09 +0000	[thread overview]
Message-ID: <1516298766.2676.29.camel@wdc.com> (raw)
In-Reply-To: <02bd01d38fa8$c09a9430$41cfbc90$@opengridcomputing.com>

On Wed, 2018-01-17@09:35 -0600, Steve Wise wrote:
> > +	if (wait_for_completion_timeout(&qp->srq_completion, 10 * HZ) > 0)
> > +		ib_process_cq_direct(cq, -1);
> > +}
> 
> Perhaps a WARN_ONCE is warranted? 

Agreed. I would also like to see a WARN_ONCE() if the timeout expires before
the completion has been signaled.

Bart.

  reply	other threads:[~2018-01-18 18:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 13:52 [PATCH 0/4] Last WQE Reached event treatment Max Gurtovoy
2018-01-17 13:52 ` [PATCH 1/4] IB/core: add support for draining Shared receive queues Max Gurtovoy
2018-01-17 15:35   ` Steve Wise
2018-01-18 18:06     ` Bart Van Assche [this message]
2018-01-17 16:11   ` Bart Van Assche
2018-01-18 10:31     ` Max Gurtovoy
2018-01-24  6:39   ` Sagi Grimberg
2018-01-24 10:20     ` Max Gurtovoy
2018-01-17 13:52 ` [PATCH 2/4] nvmet-rdma: notify QP on Last WQE Reached event arrival Max Gurtovoy
2018-01-17 15:37   ` Steve Wise
2018-01-18 18:04     ` Bart Van Assche
2018-01-17 13:52 ` [PATCH 3/4] iser-target: remove dead code Max Gurtovoy
2018-01-17 13:52 ` [PATCH 4/4] IB/srpt: notify QP on Last WQE Reached event arrival Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516298766.2676.29.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox