From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH 3/4] nvme: delete NVME_CTRL_LIVE --> NVME_CTRL_CONNECTING transition
Date: Wed, 24 Jan 2018 18:57:46 +0200 [thread overview]
Message-ID: <1516813067-1717-4-git-send-email-maxg@mellanox.com> (raw)
In-Reply-To: <1516813067-1717-1-git-send-email-maxg@mellanox.com>
There is no logical reason to move from live state to connecting
state. In case of initial connection establishment, the transition
should be NVME_CTRL_NEW --> NVME_CTRL_CONNECTING --> NVME_CTRL_LIVE.
In case of error recovery or reset, the transition should be
NVME_CTRL_LIVE --> NVME_CTRL_RESETTING --> NVME_CTRL_CONNECTING -->
NVME_CTRL_LIVE.
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/host/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 071d163..8e7ab93 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -292,7 +292,6 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
case NVME_CTRL_CONNECTING:
switch (old_state) {
case NVME_CTRL_NEW:
- case NVME_CTRL_LIVE:
case NVME_CTRL_RESETTING:
changed = true;
/* FALLTHRU */
--
1.8.3.1
next prev parent reply other threads:[~2018-01-24 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:57 [PATCH v1 0/4] Fix host side state machine Max Gurtovoy
2018-01-24 16:57 ` [PATCH 1/4] nvme: rename NVME_CTRL_RECONNECTING state to NVME_CTRL_CONNECTING Max Gurtovoy
2018-01-24 16:57 ` [PATCH 2/4] nvme-rdma: use NVME_CTRL_CONNECTING state to mark init process Max Gurtovoy
2018-01-24 16:57 ` Max Gurtovoy [this message]
2018-01-24 16:57 ` [PATCH 4/4] nvme: delete NVME_CTRL_NEW --> NVME_CTRL_LIVE transition Max Gurtovoy
2018-01-24 19:33 ` [PATCH v1 0/4] Fix host side state machine Sagi Grimberg
2018-01-25 11:31 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516813067-1717-4-git-send-email-maxg@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).