From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 1/1] nvme: implement log page low/high offset and dwords
Date: Tue, 13 Feb 2018 14:47:51 +0100 [thread overview]
Message-ID: <1518529671.3592.9.camel@suse.de> (raw)
In-Reply-To: <20180213124916.28653-2-mb@lightnvm.io>
On Tue, 2018-02-13@13:49 +0100, Matias Bj?rling wrote:
> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> + ????u8 log_page, void *log,
> + ????size_t size, size_t offset)
> +{
> + struct nvme_command c = { };
> + unsigned long dwlen = (size / 4) - 1;
Consulting my long gone maths knowledge suggests the parantheses aren't
really needed here.
--
Johannes Thumshirn ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?Storage
jthu
mshirn at suse.de ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+49 911 74053 689
SUSE
LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane
Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38
9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-02-13 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 12:49 [RFC PATCH 0/1] nvme: implement get log page offset and dwords Matias Bjørling
2018-02-13 12:49 ` [PATCH 1/1] nvme: implement log page low/high " Matias Bjørling
2018-02-13 13:47 ` Johannes Thumshirn [this message]
2018-02-13 13:53 ` Matias Bjørling
2018-02-26 11:21 ` Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518529671.3592.9.camel@suse.de \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).