From: nj.shetty@samsung.com (Nitesh Shetty)
Subject: [PATCH v3] blk: optimization for classic polling
Date: Tue, 13 Feb 2018 21:18:12 +0530 [thread overview]
Message-ID: <1518536892-2051-1-git-send-email-nj.shetty@samsung.com> (raw)
In-Reply-To: <3578876466-3733-1-git-send-email-nj.shetty@samsung.com>
This removes the dependency on interrupts to wake up task. Set task
state as TASK_RUNNING, if need_resched() returns true,
while polling for IO completion.
Earlier, polling task used to sleep, relying on interrupt to wake it up.
This made some IO take very long when interrupt-coalescing is enabled in
NVMe.
Reference:
http://lists.infradead.org/pipermail/linux-nvme/2018-February/015435.html
Changes since v2->v3:
-using __set_current_state() instead of set_current_state()
Changes since v1->v2:
-setting task state once in blk_poll, instead of multiple
callers.
Signed-off-by: Nitesh Shetty <nj.shetty at samsung.com>
---
block/blk-mq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index df93102..3574927 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3164,6 +3164,7 @@ static bool __blk_mq_poll(struct blk_mq_hw_ctx *hctx, struct request *rq)
cpu_relax();
}
+ __set_current_state(TASK_RUNNING);
return false;
}
--
2.7.4
next prev parent reply other threads:[~2018-02-13 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180208143655epcas1p444bf34705526b7839a5a135f82761aad@epcas1p4.samsung.com>
2018-02-08 14:37 ` [PATCH] blk: optimization for classic polling Nitesh Shetty
2018-02-08 15:27 ` Keith Busch
2018-02-08 16:03 ` Sagi Grimberg
2018-02-12 15:50 ` Bart Van Assche
2018-02-13 15:48 ` Nitesh Shetty [this message]
2018-02-13 16:12 ` [PATCH v3] " Jens Axboe
2018-02-13 18:56 ` [PATCH v2 RESENT] " Nitesh Shetty
2018-02-13 14:42 ` Jens Axboe
2018-02-20 13:21 ` [PATCH] " Peter Zijlstra
2018-02-20 16:27 ` Keith Busch
2018-02-20 22:37 ` Jens Axboe
2018-02-21 8:32 ` Peter Zijlstra
2018-10-10 18:52 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518536892-2051-1-git-send-email-nj.shetty@samsung.com \
--to=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox