Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH] nvme-cli add ns write protect support
Date: Fri, 03 Aug 2018 18:48:57 +0900	[thread overview]
Message-ID: <1533289737.2982.5.camel@gmail.com> (raw)
In-Reply-To: <20180803024343.4088-1-chaitanya.kulkarni@wdc.com>

Hi Chaitanya,

On Thu, 2018-08-02@19:43 -0700, Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>

> @@ -1549,6 +1573,7 @@ char *nvme_status_to_string(__u32 status)
> ?	case NVME_SC_SANITIZE_FAILED:		return "SANITIZE_FAILED: The most recent sanitize operation failed and no recovery actions has been successfully completed";
> ?	case NVME_SC_SANITIZE_IN_PROGRESS:	return "SANITIZE_IN_PROGRESS: The requested function is prohibited while a sanitize operation is in progress";
> ?	case NVME_SC_LBA_RANGE:			return "LBA_RANGE: The command references a LBA that exceeds the size of the namespace";
> +	case NVME_SC_NS_WRITE_PROTECTED:	return "Namespace Write Protected";

Not bad, but if you don't mind, can we change the description to something
like below just like the others.

NS_WRITE_PROTECTED: The command is prohibited while the namespace is write
? ? ? ? ? ? ? ? ? ? protected by the host.

This sentence is exactly as it is in TP 4005a.

Thanks,
	Minwoo Im

  reply	other threads:[~2018-08-03  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  2:43 [PATCH] nvme-cli add ns write protect support Chaitanya Kulkarni
2018-08-03  9:48 ` Minwoo Im [this message]
2018-08-06 21:39   ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533289737.2982.5.camel@gmail.com \
    --to=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox