linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH V3 1/2] nvme-cli: add minimal ana-log page support
Date: Fri, 03 Aug 2018 19:18:06 +0900	[thread overview]
Message-ID: <1533291486.2982.10.camel@gmail.com> (raw)
In-Reply-To: <20180802032819.6558-2-chaitanya.kulkarni@wdc.com>

Hi Chaitanya,

On Wed, 2018-08-01@20:28 -0700, Chaitanya Kulkarni wrote:
> @@ -1550,7 +1647,7 @@ char *nvme_status_to_string(__u32 status)
> ?	case NVME_SC_SANITIZE_IN_PROGRESS:	return "SANITIZE_IN_PROGRESS: The requested function is prohibited while a sanitize operation is in progress";
> ?	case NVME_SC_LBA_RANGE:			return "LBA_RANGE: The command references a LBA that exceeds the size of the namespace";
> ?	case NVME_SC_CAP_EXCEEDED:		return "CAP_EXCEEDED: The execution of the command has caused the capacity of the namespace to be exceeded";
> -	case NVME_SC_NS_NOT_READY:		return "NS_NOT_READY: The namespace is not ready to be accessed";
> +	case NVME_SC_NS_NOT_READY:		return "NS_NOT_READY: The namespace is not ready to be accessed as a result of a condition other than a condition that is
> reported as an Asymmetric Namespace Access condition";
> ?	case NVME_SC_RESERVATION_CONFLICT:	return "RESERVATION_CONFLICT: The command was aborted due to a conflict with a reservation held on the accessed namespace";
> ?	case NVME_SC_CQ_INVALID:		return "CQ_INVALID: The Completion Queue identifier specified in the command does not exist";
> ?	case NVME_SC_QID_INVALID:		return "QID_INVALID: The creation of the I/O Completion Queue failed due to an invalid queue identifier specified as part of the
> command. An invalid queue identifier is one that is currently in use or one that is outside the range supported by the controller";
> @@ -1590,6 +1687,9 @@ char *nvme_status_to_string(__u32 status)
> ?	case NVME_SC_COMPARE_FAILED:		return "COMPARE_FAILED: The command failed due to a miscompare during a Compare command";
> ?	case NVME_SC_ACCESS_DENIED:		return "ACCESS_DENIED: Access to the namespace and/or LBA range is denied due to lack of access rights";
> ?	case NVME_SC_UNWRITTEN_BLOCK:		return "UNWRITTEN_BLOCK: The command failed due to an attempt to read from an LBA range containing a deallocated or
> unwritten logical block";
> +	case NVME_SC_ANA_PERSISTENT_LOSS:	return "Asymmetric Namespace Access Persistent Loss";
> +	case NVME_SC_ANA_INACCESSIBLE:		return "Asymmetric Namespace Access Inaccessible";
> +	case NVME_SC_ANA_TRANSITION:		return "Asymmetric Namespace Access Transition";
> ?	default:				return "Unknown";
> ?	}
> ?}

If possible, can we change the descriptions to something like TP 4004 just
like the others or shorten descriptions? ?All the other state strings are
having statements from the doc.

Thanks,
????????Minwoo Im

  reply	other threads:[~2018-08-03 10:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02  3:28 [PATCH V3 0/2] nvme-cli: add ana-log page support Chaitanya Kulkarni
2018-08-02  3:28 ` [PATCH V3 1/2] nvme-cli: add minimal " Chaitanya Kulkarni
2018-08-03 10:18   ` Minwoo Im [this message]
2018-08-03 11:59   ` Minwoo Im
2018-08-02  3:28 ` [PATCH V3 2/2] nvme-cli: add ana-log documentation Chaitanya Kulkarni
2018-08-03 11:59   ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533291486.2982.10.camel@gmail.com \
    --to=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).