From: jianchao.w.wang@oracle.com (Jianchao Wang)
Subject: [PATCH 3/4] nvme-pci: unquiesce queues after update nr_hw_queues
Date: Tue, 11 Sep 2018 17:48:13 +0800 [thread overview]
Message-ID: <1536659294-2321-4-git-send-email-jianchao.w.wang@oracle.com> (raw)
In-Reply-To: <1536659294-2321-1-git-send-email-jianchao.w.wang@oracle.com>
updating nr_hw_queues uses bio retrieving to drain the queues, it
requires the queues to be quiesced to prevent requests from being
issued to dying hw queue, so we cannot unquiesce the queues before
that.
Signed-off-by: Jianchao Wang <jianchao.w.wang at oracle.com>
---
drivers/nvme/host/pci.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d668682..9e60edf 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2327,11 +2327,13 @@ static void nvme_reset_work(struct work_struct *work)
nvme_remove_namespaces(&dev->ctrl);
new_state = NVME_CTRL_ADMIN_ONLY;
} else {
- nvme_start_queues(&dev->ctrl);
- nvme_wait_freeze(&dev->ctrl);
+
/* hit this only when allocate tagset fails */
if (nvme_dev_add(dev))
new_state = NVME_CTRL_ADMIN_ONLY;
+
+ nvme_start_queues(&dev->ctrl);
+ nvme_wait_freeze(&dev->ctrl);
nvme_unfreeze(&dev->ctrl);
}
--
2.7.4
next prev parent reply other threads:[~2018-09-11 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 9:48 [RFC PATCH 0/4] blk-mq: introduce bio retrieve mechanism Jianchao Wang
2018-09-11 9:48 ` [PATCH 1/4] " Jianchao Wang
2018-09-11 9:48 ` [PATCH 2/4] blk-mq: retrieve bios before update nr_hw_queues Jianchao Wang
2018-09-11 9:48 ` Jianchao Wang [this message]
2018-09-11 9:48 ` [PATCH 4/4] nvme-pci: discard the cq_vector checking in nvme_queue_rq Jianchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536659294-2321-4-git-send-email-jianchao.w.wang@oracle.com \
--to=jianchao.w.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).