From: jianchao.w.wang@oracle.com (Jianchao Wang)
Subject: [PATCH 4/4] nvme-pci: discard the cq_vector checking in nvme_queue_rq
Date: Tue, 11 Sep 2018 17:48:14 +0800 [thread overview]
Message-ID: <1536659294-2321-5-git-send-email-jianchao.w.wang@oracle.com> (raw)
In-Reply-To: <1536659294-2321-1-git-send-email-jianchao.w.wang@oracle.com>
updating nr_hw_queue uses bios retrieving to drain queues, so we
needn't the the cq_vector checking any more.
Signed-off-by: Jianchao Wang <jianchao.w.wang at oracle.com>
---
drivers/nvme/host/pci.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 9e60edf..615192f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -813,13 +813,6 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
struct nvme_command cmnd;
blk_status_t ret;
- /*
- * We should not need to do this, but we're still using this to
- * ensure we can drain requests on a dying queue.
- */
- if (unlikely(nvmeq->cq_vector < 0))
- return BLK_STS_IOERR;
-
ret = nvme_setup_cmd(ns, req, &cmnd);
if (ret)
return ret;
--
2.7.4
prev parent reply other threads:[~2018-09-11 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 9:48 [RFC PATCH 0/4] blk-mq: introduce bio retrieve mechanism Jianchao Wang
2018-09-11 9:48 ` [PATCH 1/4] " Jianchao Wang
2018-09-11 9:48 ` [PATCH 2/4] blk-mq: retrieve bios before update nr_hw_queues Jianchao Wang
2018-09-11 9:48 ` [PATCH 3/4] nvme-pci: unquiesce queues after " Jianchao Wang
2018-09-11 9:48 ` Jianchao Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536659294-2321-5-git-send-email-jianchao.w.wang@oracle.com \
--to=jianchao.w.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).