From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
nbd@other.debian.org, linux-scsi@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH 02/10] block: add a queue_limits_commit_update_frozen helper
Date: Mon, 13 Jan 2025 08:20:57 +0100 [thread overview]
Message-ID: <15cb40c2-df67-423d-a15c-c55e2bb2b8a9@suse.de> (raw)
In-Reply-To: <20250108092520.1325324-3-hch@lst.de>
On 1/8/25 10:24, Christoph Hellwig wrote:
> Add a helper that freezes the queue, updates the queue limits and
> unfreezes the queue and convert all open coded versions of that to the
> new helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
> ---
> block/blk-integrity.c | 4 +---
> block/blk-settings.c | 24 ++++++++++++++++++++++++
> block/blk-zoned.c | 7 +------
> drivers/block/virtio_blk.c | 4 +---
> drivers/scsi/sd.c | 17 +++++------------
> drivers/scsi/sr.c | 5 +----
> include/linux/blkdev.h | 2 ++
> 7 files changed, 35 insertions(+), 28 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-01-13 7:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 9:24 fix queue freeze and limit locking order v2 Christoph Hellwig
2025-01-08 9:24 ` [PATCH 01/10] block: fix docs for freezing of queue limits updates Christoph Hellwig
2025-01-08 10:19 ` Ming Lei
2025-01-13 7:19 ` Hannes Reinecke
2025-01-08 9:24 ` [PATCH 02/10] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-08 10:20 ` Ming Lei
2025-01-13 7:20 ` Hannes Reinecke [this message]
2025-01-08 9:25 ` [PATCH 03/10] block: don't update BLK_FEAT_POLL in __blk_mq_update_nr_hw_queues Christoph Hellwig
2025-01-08 10:17 ` Damien Le Moal
2025-01-08 10:31 ` Ming Lei
2025-01-08 15:27 ` Christoph Hellwig
2025-01-09 0:05 ` Damien Le Moal
2025-01-09 2:18 ` Ming Lei
2025-01-08 10:54 ` Nilay Shroff
2025-01-13 7:23 ` Hannes Reinecke
2025-01-08 9:25 ` [PATCH 04/10] block: add a store_limit operations for sysfs entries Christoph Hellwig
2025-01-08 10:33 ` Ming Lei
2025-01-13 7:24 ` Hannes Reinecke
2025-01-08 9:25 ` [PATCH 05/10] block: fix queue freeze vs limits lock order in sysfs store methods Christoph Hellwig
2025-01-08 10:18 ` Damien Le Moal
2025-01-08 10:38 ` Ming Lei
2025-01-08 15:29 ` Christoph Hellwig
2025-01-13 7:25 ` Hannes Reinecke
2025-01-08 9:25 ` [PATCH 06/10] nvme: fix queue freeze vs limits lock order Christoph Hellwig
2025-01-08 10:39 ` Ming Lei
2025-01-08 9:25 ` [PATCH 07/10] nbd: " Christoph Hellwig
2025-01-08 10:40 ` Ming Lei
2025-01-08 9:25 ` [PATCH 08/10] usb-storage: " Christoph Hellwig
2025-01-08 10:41 ` Ming Lei
2025-01-08 9:25 ` [PATCH 09/10] loop: refactor queue limits updates Christoph Hellwig
2025-01-08 10:20 ` Damien Le Moal
2025-01-08 10:42 ` Ming Lei
2025-01-08 10:56 ` Nilay Shroff
2025-01-08 9:25 ` [PATCH 10/10] loop: fix queue freeze vs limits lock order Christoph Hellwig
2025-01-08 10:20 ` Damien Le Moal
2025-01-08 10:44 ` Ming Lei
2025-01-08 10:57 ` Nilay Shroff
2025-01-08 10:51 ` fix queue freeze and limit locking order v2 Johannes Thumshirn
-- strict thread matches above, loose matches on Subject: below --
2025-01-06 10:06 RFC: fix queue freeze and limit locking order (alt take) Christoph Hellwig
2025-01-06 10:06 ` [PATCH 02/10] block: add a queue_limits_commit_update_frozen helper Christoph Hellwig
2025-01-06 10:41 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15cb40c2-df67-423d-a15c-c55e2bb2b8a9@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=nilay@linux.ibm.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox