Re: [PATCH v7 02/16] blkcg: Added a app identifier support for blkcg

Hannes Reinecke
2021-01-11T07:30:32Z

On 1/6/21 11:00 PM, Muneendra wrote:
> This Patch added a unique application identifier i.e
> fc_app_id member in blkcg which allows identification of traffic
> sources at an individual cgroup based Applications
> (ex:virtual machine (VM))level in both host and
> fabric infrastructure.
>
> Added a new function blkcg_get_fc_appid to
> grab the app identifier associated with a bio.
>
> Added a new function blkcg_set_fc_appid to
> set the app identifier in a blkcgrp associated with cgroup id
>
> Added a new config BLK_CGROUP_FC_APPID and moved the changes
> under this config
>
> Signed-off-by: Muneendra <muneendra.kumar@broadcom.com>
>
> ---
> v7:
> Modified the Kconfig file
>
> v6:
> Modified the Kconfig file as per standard specified
> in Documentation/process/coding-style.rst
>
> v5:
> Renamed the arguments appropriatley
> Renamed APPID_LEN to FC_APPID_LEN
> Moved the input validation at the begining of the function
> Modified the comments
>
> v4:
> No change
>
> v3:
> Renamed the functions and app_id to more specific
>
> Addressed the reference leaks in blkcg_set_app_identifier
>
> Added a new config BLK_CGROUP_FC_APPID and moved the changes
> under this config
>
> Added blkcg_get_fc_appid,blkcg_set_fc_appid as inline functions
>
> v2:
> renamed app_identifier to app_id
> removed the sysfs interface blkio.app_identifie under
> ---
> block/Kconfig | 9 ++++++
> include/linux/blk-cgroup.h | 56 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer