public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Zheng Wu <wu.zheng@intel.com>
To: linux-nvme@lists.infradead.org
Cc: Wu Zheng <wu.zheng@intel.com>
Subject: [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs
Date: Thu, 17 Jun 2021 12:05:52 -0400	[thread overview]
Message-ID: <1623945952-18861-1-git-send-email-wu.zheng@intel.com> (raw)

From: Wu Zheng <wu.zheng@intel.com>

Subnqn isn't supported in P4500/P4600 SSDs.
It's a fixed unavailable value in each P4500/P4600 SSD.

Multiple SSDs need to return the different subnqn when SSDs are initialization.
To P4500/P4600 SSDs, in nvme_init_subnqn, id->subnqn is not null and
it's from P4500/P4600. However, multiple P4500/P4600 SSDs return the same subnqn.
It causes the possible initialization failure.

To fix this, the flag of NVME_QUIRK_IGNORE_DEV_SUBNQN need to be added to
driver_data of P4500/P4600 for nvme_id_table.

Signed-off-by: Zheng Wu <wu.zheng@intel.com>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ca2ee80..953ea3d 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3326,7 +3326,8 @@ static const struct pci_device_id nvme_id_table[] = {
 				NVME_QUIRK_DEALLOCATE_ZEROES, },
 	{ PCI_VDEVICE(INTEL, 0x0a54),	/* Intel P4500/P4600 */
 		.driver_data = NVME_QUIRK_STRIPE_SIZE |
-				NVME_QUIRK_DEALLOCATE_ZEROES, },
+				NVME_QUIRK_DEALLOCATE_ZEROES |
+				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
 	{ PCI_VDEVICE(INTEL, 0x0a55),	/* Dell Express Flash P4600 */
 		.driver_data = NVME_QUIRK_STRIPE_SIZE |
 				NVME_QUIRK_DEALLOCATE_ZEROES, },
-- 
2.7.4



             reply	other threads:[~2021-12-10  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 16:05 Zheng Wu [this message]
2021-12-10 17:31 ` [PATCH] nvme: fix possible initialization failure for P4500/P4600 SSDs Keith Busch
  -- strict thread matches above, loose matches on Subject: below --
2021-06-21 23:07 Zheng Wu
2022-01-10 16:03 ` Keith Busch
2022-01-26 16:14 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1623945952-18861-1-git-send-email-wu.zheng@intel.com \
    --to=wu.zheng@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox