[PATCH 1/2] nvme: NUMA locality information for fabrics

[hare@suse.com (Hannes Reinecke)]

On 10/8/18 12:22 PM, Matias Bj?rling wrote:
> 
> 
> On 10/08/2018 12:04 PM, Christoph Hellwig wrote:
[ .. ]
>>> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
>>> index d668682f91df..b5d37aacf212 100644
>>> --- a/drivers/nvme/host/pci.c
>>> +++ b/drivers/nvme/host/pci.c
>>> @@ -2517,6 +2517,7 @@ static int nvme_probe(struct pci_dev *pdev, 
>>> const struct pci_device_id *id)
>>> ????? dev_info(dev->ctrl.device, "pci function %s\n", 
>>> dev_name(&pdev->dev));
>>> +??? dev->ctrl.node_id = node;
>>> ????? nvme_get_ctrl(&dev->ctrl);
>>> ????? async_schedule(nvme_async_probe, dev);
>>
>> This changes behavior as node might remain NUMA_NO_NODE when the code
>> above sets the device node to first_memory_node now when
>> it would otherwise be NUMA_NO_NODE.? Then again that code makes no
>> sense to me to start with - Matias added it with the blk-mq conversion,
>> so maybe he remembers why we do it to start with?? If we want to fix
>> up nodes like that it seems like we should do it in the driver core
>> or the PCI core.
>>
> 
> Back in the days it was carried over to make sure the structures was 
> allocated from the same node as the pcie device.
> 
Which really is what this patch is trying to do.
Or am I wrong?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare at suse.com			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)