From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 08/20] nvme-auth: remove redundant if statement
Date: Tue, 15 Nov 2022 03:58:41 +0000 [thread overview]
Message-ID: <1630785a-2d41-8f14-2b53-a4e3bc2eafa8@nvidia.com> (raw)
In-Reply-To: <20221113112424.1049834-9-sagi@grimberg.me>
On 11/13/22 03:24, Sagi Grimberg wrote:
> No one passes NVME_QID_ANY to nvme_auth_negotiate.
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-11-15 3:58 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 11:24 [PATCH v2 00/20] nvme: fixes, cleanups and enhancements to the dhchap-auth host code Sagi Grimberg
2022-11-13 11:24 ` [PATCH v2 01/20] nvme-auth: rename __nvme_auth_[reset|free] to nvme_auth[reset|free]_dhchap Sagi Grimberg
2022-11-15 3:50 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 02/20] nvme-auth: rename authentication work elements Sagi Grimberg
2022-11-13 13:11 ` Hannes Reinecke
2022-11-15 3:52 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 03/20] nvme-auth: remove symbol export from nvme_auth_reset Sagi Grimberg
2022-11-15 3:52 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 04/20] nvme-auth: don't re-authenticate if the controller is not LIVE Sagi Grimberg
2022-11-15 3:53 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 05/20] nvme-auth: remove redundant buffer deallocations Sagi Grimberg
2022-11-15 3:54 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 06/20] nvme-auth: don't ignore key generation failures when initializing ctrl keys Sagi Grimberg
2022-11-15 3:56 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 07/20] nvme-auth: don't override ctrl keys before validation Sagi Grimberg
2022-11-15 3:58 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 08/20] nvme-auth: remove redundant if statement Sagi Grimberg
2022-11-15 3:58 ` Chaitanya Kulkarni [this message]
2022-11-13 11:24 ` [PATCH v2 09/20] nvme-auth: don't keep long lived 4k dhchap buffer Sagi Grimberg
2022-11-15 4:01 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 10/20] nvme-auth: guarantee dhchap buffers under memory pressure Sagi Grimberg
2022-11-15 4:04 ` Chaitanya Kulkarni
2022-11-15 8:09 ` Sagi Grimberg
2022-11-13 11:24 ` [PATCH v2 11/20] nvme-auth: clear sensitive info right after authentication completes Sagi Grimberg
2022-11-15 4:06 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 12/20] nvme-auth: remove redundant deallocations Sagi Grimberg
2022-11-13 13:11 ` Hannes Reinecke
2022-11-15 4:09 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 13/20] nvme-auth: no need to reset chap contexts on re-authentication Sagi Grimberg
2022-11-15 4:10 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 14/20] nvme-auth: check chap ctrl_key once constructed Sagi Grimberg
2022-11-13 13:12 ` Hannes Reinecke
2022-11-15 4:13 ` Chaitanya Kulkarni
2022-11-15 4:13 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 15/20] nvme: move nvme_dhchap_queue_context declaration to nvme.h header Sagi Grimberg
2022-11-15 4:20 ` Chaitanya Kulkarni
2022-11-15 10:03 ` Christoph Hellwig
2022-11-13 11:24 ` [PATCH v2 16/20] nvme-auth: convert dhchap_auth_list to an array Sagi Grimberg
2022-11-13 11:24 ` [PATCH v2 17/20] nvme-auth: remove redundant auth_work flush Sagi Grimberg
2022-11-15 4:15 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 18/20] nvme-auth: have dhchap_auth_work wait for queues auth to complete Sagi Grimberg
2022-11-13 11:24 ` [PATCH v2 19/20] nvme-tcp: stop auth work after tearing down queues in error recovery Sagi Grimberg
2022-11-15 4:18 ` Chaitanya Kulkarni
2022-11-13 11:24 ` [PATCH v2 20/20] nvme-rdma: " Sagi Grimberg
2022-11-15 4:18 ` Chaitanya Kulkarni
2022-11-15 10:11 ` [PATCH v2 00/20] nvme: fixes, cleanups and enhancements to the dhchap-auth host code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1630785a-2d41-8f14-2b53-a4e3bc2eafa8@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox