From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04429CCF9F8 for ; Fri, 7 Nov 2025 08:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yfLvjLP1WtT0fDdb9ALr5xYXgUaeMcxf0N51cIO18kQ=; b=o8i1HYx4n8WL5Bs0JsU7ARKonn DsJGWFW7jtHSfCf32llbXvcm+T6AGEbVSk9P2hw5OqK8COZRsFoPIBqAx7suk4IbrkoaARc1DAUle n8i9xfia0HMqsrUNBVHaHvZ5Tj9tQIiUv2vLo42w0RjO25KpXsMOU5QmP0Q58v6QMam/Ng+PeLOiF bnSn0Ze112w2Dc5oz2Z4axRWWg0SYLefQkjkUDFs18N0dqO8h2vymQHxkcXoUqzDuzoA4IxTlCh+M 7QY3U5gg2YeSIDmK0VLNdNPFcvZ5oBOyrNCIvmaQcFbu06BTe/vVmmrM+CThLwC4bWRq07oCnprzb y7mFu5yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHHra-0000000GtDK-2tGr; Fri, 07 Nov 2025 08:30:30 +0000 Received: from smtp-out1.suse.de ([195.135.223.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vHHrX-0000000GtAp-0L5i for linux-nvme@lists.infradead.org; Fri, 07 Nov 2025 08:30:28 +0000 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9DD912124F; Fri, 7 Nov 2025 08:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762504223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfLvjLP1WtT0fDdb9ALr5xYXgUaeMcxf0N51cIO18kQ=; b=Pncd/QsMSchY5lA4BYpHjG9XRSEDwdC8/lmgt3VltNg5E1n1BGFIA10orZ40qVHYDrtEDz POJt23+poN9JOFoAnVe8GEqMaPaBkTeWfnzd7h9ZssLKs3FNQsWWLQ2sz/lilJ7vOqT1EF bd54eJ6OVKFwfbBP2WNg/o+lIvwVa7Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762504223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfLvjLP1WtT0fDdb9ALr5xYXgUaeMcxf0N51cIO18kQ=; b=ORvUOA/PiFAXk+h5gcPgGerBil3ygivizaZiobiPoJmH81o8W66zQ4obvXSe6CfCHJMzXt MTT6NnUveR0+DfBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Pncd/QsM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="ORvUOA/P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762504223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfLvjLP1WtT0fDdb9ALr5xYXgUaeMcxf0N51cIO18kQ=; b=Pncd/QsMSchY5lA4BYpHjG9XRSEDwdC8/lmgt3VltNg5E1n1BGFIA10orZ40qVHYDrtEDz POJt23+poN9JOFoAnVe8GEqMaPaBkTeWfnzd7h9ZssLKs3FNQsWWLQ2sz/lilJ7vOqT1EF bd54eJ6OVKFwfbBP2WNg/o+lIvwVa7Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762504223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfLvjLP1WtT0fDdb9ALr5xYXgUaeMcxf0N51cIO18kQ=; b=ORvUOA/PiFAXk+h5gcPgGerBil3ygivizaZiobiPoJmH81o8W66zQ4obvXSe6CfCHJMzXt MTT6NnUveR0+DfBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4A88B132DD; Fri, 7 Nov 2025 08:30:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2kYzEB+uDWkDSgAAD6G6ig (envelope-from ); Fri, 07 Nov 2025 08:30:23 +0000 Message-ID: <1646ecdc-7119-43d3-9f1e-a0ed481d38f5@suse.de> Date: Fri, 7 Nov 2025 09:30:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] nvmet-auth: update sc_c in target host hash calculation To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis References: <20251106231711.3189836-1-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20251106231711.3189836-1-alistair.francis@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9DD912124F X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com,kernel.org,kernel.dk,lst.de,grimberg.me,nvidia.com,lists.infradead.org]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,suse.de:dkim] X-Rspamd-Action: no action X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251107_003027_281614_CBE2A0B9 X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 11/7/25 00:17, alistair23@gmail.com wrote: > From: Alistair Francis > > Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added > the sc_c variable to the dhchap queue context structure which is > appropriately set during negotiate and then used in the host response. > > This breaks secure concat connections with a Linux target as the target > code wasn't updated at the same time. This patch fixes this by adding a > new sc_c variable to the host hash calculations. > > Fixes: 7e091add9c43 ("nvme-auth: update sc_c in host response") > Signed-off-by: Alistair Francis > --- > drivers/nvme/target/auth.c | 4 ++-- > drivers/nvme/target/fabrics-cmd-auth.c | 1 + > drivers/nvme/target/nvmet.h | 1 + > 3 files changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich