From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
David Jeffery <djeffery@redhat.com>,
Laurence Oberman <loberman@redhat.com>,
Paolo Valente <paolo.valente@linaro.org>, Jan Kara <jack@suse.cz>,
Sasha Levin <sashal@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: New warning in nvme_setup_discard
Date: Tue, 27 Jul 2021 17:12:03 +0200 [thread overview]
Message-ID: <17691292.WCMSeNvH9h@natalenko.name> (raw)
In-Reply-To: <YPfUOKrxGs6FjaOZ@T590>
Hello.
On středa 21. července 2021 10:00:56 CEST Ming Lei wrote:
> > I'm still hammering v5.14-rc2 + your patch, and I cannot reproduce the
> > issue. Given I do not have a reliable reproducer (I'm just firing up the
> > kernel build, and the issue pops up eventually, sooner or later, but
> > usually within a couple of first tries), for how long I should hammer it
> > for your fix to be considered proven?
>
> You mentioned that the issue is reproducible with v5.14-rc, that means
> it can be always reproduced in limited time(suppose it is A). If the issue
> can't be reproduced any more after applying the patch in long enough time
> B(B >> A), we can think it is fixed by the patch.
>
> For example, if A is one hour, we can set B as 5*A or bigger to simulate
> the long enough time.
With your patch the issue is still not reproducible for me. Hence, from my
side the patch looks to be verified.
Thanks.
--
Oleksandr Natalenko (post-factum)
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-07-27 15:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 13:56 New warning in nvme_setup_discard Oleksandr Natalenko
2021-07-15 14:19 ` Greg Kroah-Hartman
2021-07-15 14:21 ` Oleksandr Natalenko
2021-07-15 21:37 ` Laurence Oberman
2021-07-16 5:50 ` Oleksandr Natalenko
2021-07-16 2:16 ` Ming Lei
2021-07-16 5:53 ` Oleksandr Natalenko
2021-07-16 9:33 ` Ming Lei
2021-07-16 10:03 ` Oleksandr Natalenko
2021-07-16 10:41 ` Ming Lei
2021-07-16 12:56 ` Oleksandr Natalenko
2021-07-17 9:35 ` Ming Lei
2021-07-17 12:11 ` Oleksandr Natalenko
2021-07-17 12:19 ` Oleksandr Natalenko
2021-07-17 12:35 ` Oleksandr Natalenko
2021-07-19 1:40 ` Ming Lei
2021-07-19 6:27 ` Oleksandr Natalenko
2021-07-20 9:05 ` Oleksandr Natalenko
2021-07-21 8:00 ` Ming Lei
2021-07-27 15:12 ` Oleksandr Natalenko [this message]
2021-07-27 15:58 ` Ming Lei
2021-07-28 13:44 ` Oleksandr Natalenko
2021-07-28 15:53 ` Ming Lei
2021-07-28 16:38 ` Oleksandr Natalenko
2021-07-29 3:33 ` Ming Lei
2021-07-29 9:29 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17691292.WCMSeNvH9h@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=paolo.valente@linaro.org \
--cc=sagi@grimberg.me \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).