From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA37DC433E0 for ; Wed, 24 Feb 2021 05:52:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B3C160200 for ; Wed, 24 Feb 2021 05:52:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B3C160200 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5P77qLn0x0xpW6qHcumztNvguU5Y9BuDvybMUqqHzCc=; b=dtQS/lwxheq7ipZRW6maB+G+7 w5EVPSNx+6cgHx6ETH70dPMsX+Ej+FhDs4jt6oisO1AB/0id1sbFtYnxUKiGvkN2iJxvGlYwK8Ik8 M0k6UeV+tnPro2MQF97GzfpyM59Rdj8kfZaZLAkEPRfl5p2vJmORXcpO2Xt0ChyMEt/pmf8qkcwak a9j7N9+jaPrlu31UeGM5bUO9WXFaIPB3+9Fqb7OfWxZ119PrxYcdoHs01JtFcX0ens2Wkp3I7iCwh NLLZatsmpI4DBcXo1VuqqVATm22C2MKPnC0xuAwnXIQf3lCz35H2Spqbxyz8cr9yvGxZDTzM2t40i Mk3ZLj/ZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEn68-0008Q4-Cz; Wed, 24 Feb 2021 05:52:33 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEn65-0008Ox-0l for linux-nvme@lists.infradead.org; Wed, 24 Feb 2021 05:52:31 +0000 Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4DllP72tw6z13xYZ; Wed, 24 Feb 2021 13:49:47 +0800 (CST) Received: from dggema772-chm.china.huawei.com (10.1.198.214) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 24 Feb 2021 13:52:20 +0800 Received: from [10.169.42.93] (10.169.42.93) by dggema772-chm.china.huawei.com (10.1.198.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Wed, 24 Feb 2021 13:52:20 +0800 Subject: Re: [PATCH] nvme-rdma: fix crash for no IO queues To: Chaitanya Kulkarni , "linux-nvme@lists.infradead.org" References: <20210223072602.3196-1-lengchao@huawei.com> From: Chao Leng Message-ID: <1ac356d5-f154-699e-e929-e9f351b7da07@huawei.com> Date: Wed, 24 Feb 2021 13:52:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.169.42.93] X-ClientProxiedBy: dggeme720-chm.china.huawei.com (10.1.199.116) To dggema772-chm.china.huawei.com (10.1.198.214) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_005229_964915_63A5A077 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kbusch@kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2021/2/24 6:03, Chaitanya Kulkarni wrote: > On 2/22/21 23:30, Chao Leng wrote: >> A crash happens when set feature(NVME_FEAT_NUM_QUEUES) timeout in nvme >> over rdma(roce) reconnection, the reason is use the queue which is not >> alloced. >> >> If it is not discovery and no io queues, the connection should fail. >> >> Signed-off-by: Chao Leng > > Can you please share more information about > > "when set feature(NVME_FEAT_NUM_QUEUES) timeout" scenario ? Inject a large number of bit errors intermittently. This will cause request time out, and then reconnection will trigger by error recovery. The requests of reconnect may also time out. If set feature (NVME_FEAT_NUM_QUEUES, which is called by nvme_set_queue_count) time out and the reconnection may success. Block will continue send request, and then crash due to use unallocated queue. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme