From: John Meneghini <jmeneghi@redhat.com>
To: Hannes Reinecke <hare@suse.de>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
kbusch@kernel.org, martin.petersen@oracle.com,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org
Cc: bgurney@redhat.com, axboe@kernel.dk, emilne@redhat.com,
gustavoars@kernel.org, hch@lst.de, james.smart@broadcom.com,
kees@kernel.org, linux-hardening@vger.kernel.org,
njavali@marvell.com, sagi@grimberg.me
Subject: Re: [PATCH v10 11/11] scsi: qla2xxx: Fix 2 memcpy field-spanning write issue
Date: Tue, 30 Sep 2025 05:38:35 -0400 [thread overview]
Message-ID: <1b17fc45-ba6e-4fb3-9352-a6ec0ae913f2@redhat.com> (raw)
In-Reply-To: <49b31606-29fc-43ea-973b-b317c53161db@suse.de>
On 9/26/25 5:29 AM, Hannes Reinecke wrote:
> On 9/26/25 11:00, Gustavo A. R. Silva wrote:
>> Hi,
>>
>> Shouldn't this patch be removed from this series, since it's going to be
>> reverted anyways?
>>
> yes. To my understanding the FPIN patch series has been queued in
> scsi-queue anyway, so it would be better to just send an incremental
> patch on top of that.
> Especially as Martin has already indicated that he will _not_ rebase
> his tree.
This V10 patch series is based on nvme-v18.
I don't see the revert in scsi/6.18/scsi-queue yet
> Best to just send this patch as a stand-alone patch, and then rebase
> any not-yet-upstreamed patchsets on top of that.
I'd prefer to merge this patch with the FPIN-LI patch series. There is to good way to test this field-spanning write fix w/out the FPIN_LI patches,
and the last time we cherry-picked and merged this fix it only led to confusion.
I think we should keep these together. I will add Gustavo's new fix to my V11 patch series.
/John
> Cheers,
>
> Hannes
next prev parent reply other threads:[~2025-09-30 9:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 0:01 [PATCH v10 00/11] nvme-fc: FPIN link integrity handling John Meneghini
2025-09-26 0:01 ` [PATCH v10 01/11] fc_els: use 'union fc_tlv_desc' John Meneghini
2025-09-29 17:44 ` Justin Tee
2025-09-30 10:15 ` John Meneghini
2025-09-26 0:01 ` [PATCH v10 02/11] nvme: add NVME_CTRL_MARGINAL flag John Meneghini
2025-09-26 0:01 ` [PATCH v10 03/11] nvme-fc: marginal path handling John Meneghini
2025-10-03 10:15 ` Christoph Hellwig
2025-09-26 0:01 ` [PATCH v10 04/11] nvme: sysfs: emit the marginal path state in show_state() John Meneghini
2025-09-26 0:01 ` [PATCH v10 05/11] nvme-multipath: queue-depth support for marginal paths John Meneghini
2025-09-26 0:01 ` [PATCH v10 06/11] nvme-fc: add nvme_fc_modify_rport_fpin_state() John Meneghini
2025-09-26 0:01 ` [PATCH v10 07/11] scsi: scsi_transport_fc: add fc_host_fpin_set_nvme_rport_marginal() John Meneghini
2025-09-29 17:45 ` Justin Tee
2025-09-30 10:17 ` John Meneghini
2025-09-26 0:01 ` [PATCH v10 08/11] scsi: lpfc: enable FPIN notification for NVMe John Meneghini
2025-09-26 0:01 ` [PATCH v10 09/11] scsi: qla2xxx: " John Meneghini
2025-09-26 0:01 ` [PATCH v10 10/11] scsi: scsi_transport_fc: user support for clearing NVME_CTRL_MARGINAL John Meneghini
2025-09-26 0:02 ` [PATCH v10 11/11] scsi: qla2xxx: Fix 2 memcpy field-spanning write issue John Meneghini
2025-09-26 9:00 ` Gustavo A. R. Silva
2025-09-26 9:29 ` Hannes Reinecke
2025-09-30 9:38 ` John Meneghini [this message]
2025-09-30 9:24 ` John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b17fc45-ba6e-4fb3-9352-a6ec0ae913f2@redhat.com \
--to=jmeneghi@redhat.com \
--cc=axboe@kernel.dk \
--cc=bgurney@redhat.com \
--cc=emilne@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox