Re: [PATCH 4/5] lpfc: enable FPIN notification for NVMe

[Hannes Reinecke <hare@suse.de>]

On 5/6/25 23:50, Justin Tee wrote:
> Hi Hannes,
> 
> Maybe the last tidbit from my previous email got lost.  May we also
> exclude lpfc driver’s target mode from calling nvme_fc_fpin_rcv?
> 
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 396ed1a05bc9..09713cc57e94 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -10253,7 +10253,8 @@ lpfc_els_rcv_fpin(struct lpfc_vport *vport,
> void *p, u32 fpin_length)
>                          fc_host_fpin_rcv(lpfc_shost_from_vport(vport),
>                                           fpin_length, (char *)fpin, 0);
>   #if (IS_ENABLED(CONFIG_NVME_FC))
> -                       if (vport->cfg_enable_fc4_type & LPFC_ENABLE_NVME)
> +                       if (vport->cfg_enable_fc4_type & LPFC_ENABLE_NVME &&
> +                           !phba->nvmet_support)
>                                  nvme_fc_fpin_rcv(vport->localport,
>                                                   fpin_length, (char *)fpin);
>   #endif
> 
Sure we could. But it's not that the target mode does anything with the 
marginal ports, so actual effects would be negligible.
Question, though: Why _should_ it be excluded? I would have thought that
the target would be interested in link integrity notifications, no?
(In general terms. Of course there is no code for it.)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich