From: Heiner Kallweit <hkallweit1@gmail.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Subject: [PATCH] nvme: use lighter smp barriers in nvme_irq
Date: Sun, 14 Feb 2021 17:24:55 +0100 [thread overview]
Message-ID: <1c90fd6a-d991-b347-479c-2c8ae5a4c51f@gmail.com> (raw)
Based on the description we should be fine using the less heavy-weight
smp barriers here. On x86 this would be compiler barriers only.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/nvme/host/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7b6632c00..59fee4a60 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1066,10 +1066,10 @@ static irqreturn_t nvme_irq(int irq, void *data)
* The rmb/wmb pair ensures we see all updates from a previous run of
* the irq handler, even if that was on another CPU.
*/
- rmb();
+ smp_rmb();
if (nvme_process_cq(nvmeq))
ret = IRQ_HANDLED;
- wmb();
+ smp_wmb();
return ret;
}
--
2.30.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2021-02-14 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 16:24 Heiner Kallweit [this message]
2021-02-16 23:59 ` [PATCH] nvme: use lighter smp barriers in nvme_irq Chaitanya Kulkarni
2021-02-17 7:26 ` Heiner Kallweit
2021-02-18 1:41 ` Chaitanya Kulkarni
2021-02-18 3:28 ` Keith Busch
2021-02-18 4:06 ` Chaitanya Kulkarni
2021-02-18 21:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c90fd6a-d991-b347-479c-2c8ae5a4c51f@gmail.com \
--to=hkallweit1@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox