RE: nvme-pci: disable write zeros support on SSDs

[Rita Lin <ritach_lin@phison.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1621 bytes --]

Dear Christoph,

Thank you for your advice.
Please find the updated patch in the attached file.

Rita LinÁÖݽìÓ
+886-37-586-896 Ext.80051
ritach_lin@phison.com


-----Original Message-----
From: Christoph Hellwig [mailto:hch@lst.de]
Sent: Thursday, September 22, 2022 1:53 PM
To: Rita Lin <ritach_lin@phison.com>
Cc: Christoph Hellwig <hch@lst.de>; Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>; Sagi Grimberg <sagi@grimberg.me>; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; üSêɬ| <redd_huang@phison.com>; Tina Hsu <tina_hsu@phison.com>; Vita Hsueh (ѦÒÁÙ») <Vita.Hsueh@quantatw.com>; Wang, Audrey <audrey.wang@hp.com>
Subject: Re: nvme-pci: disable write zeros support on SSDs

On Thu, Sep 22, 2022 at 05:50:52AM +0000, Rita Lin wrote:
> Dear Christoph,
>
> Thank you for your reply.
> These SSDs do support write 0 command and the function was tested without issue.
> But since these SSDs are DRAMless products, the write 0 command will take a lot longer to complete which had impacted the product performance.
> Due to the FW had been frozen, we would like to check if we could apply CL for these 2 products.

please add a comment explaining this to the IDs entry.


This message and any attachments are confidential and may be legally privileged. Any unauthorized review, use or distribution by anyone other than the intended recipient is strictly prohibited. If you are not the intended recipient, please immediately notify the sender, completely delete the message and any attachments, and destroy all copies. Your cooperation will be highly appreciated.

[-- Attachment #2: 0001-PATCH-Add-Phison-E3C-E4C-Disable-Write-Zero.patch --]
[-- Type: application/octet-stream, Size: 1354 bytes --]

From 25a32a85ffa26cbbf0649d2b5457f6e13ec85903 Mon Sep 17 00:00:00 2001
From: Tina Hsu <tina_hsu@phison.corp-partner.google.com>
Date: Thu, 22 Sep 2022 14:16:30 +0800
Subject: [PATCH] [PATCH] Add Phison E3C/E4C Disable Write Zero

E3C/E4C SSDs do support write 0 command and the function was tested without issue.
But since these SSDs are DRAMless products, the write 0 command will take a lot longer to complete which had impacted the product performance.
Due to the FW had been frozen, we would like to check if we could apply CL for these 2 products.
---
 drivers/nvme/host/pci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 98864b853eef..67d3335e9cc8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3470,6 +3470,10 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1987, 0x5016),	/* Phison E16 */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x1987, 0x5019),  /* phison E19 */
+		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+	{ PCI_DEVICE(0x1987, 0x5021),   /* Phison E21 */
+		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
 	{ PCI_DEVICE(0x1b4b, 0x1092),	/* Lexar 256 GB SSD */
 		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
-- 
2.25.1